You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2020/08/15 23:00:02 UTC
[GitHub] [druid] medb opened a new pull request #10290: Upgrade Guava to 28.2-jre version
medb opened a new pull request #10290:
URL: https://github.com/apache/druid/pull/10290
### Description
Upgrades Guava version to improve compatibility with Hadoop 3.2+ and other newest dependencies.
<hr>
This PR has:
- [ ] been self-reviewed.
- [ ] using the [concurrency checklist](https://github.com/apache/druid/blob/master/dev/code-review/concurrency.md) (Remove this item if the PR doesn't have any relation to concurrency.)
- [ ] added documentation for new or modified features or behaviors.
- [ ] added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
- [ ] added or updated version, license, or notice information in [licenses.yaml](https://github.com/apache/druid/blob/master/licenses.yaml)
- [ ] added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
- [ ] added unit tests or modified existing tests to cover new code paths, ensuring the threshold for [code coverage](https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md) is met.
- [ ] added integration tests.
- [ ] been tested in a test Druid cluster.
<!-- Check the items by putting "x" in the brackets for the done things. Not all of these items apply to every PR. Remove the items which are not done or not relevant to the PR. None of the items from the checklist above are strictly necessary, but it would be very helpful if you at least self-review the PR. -->
<hr>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] clintropolis commented on pull request #10290: Upgrade Guava to 28.2-jre version
Posted by GitBox <gi...@apache.org>.
clintropolis commented on pull request #10290:
URL: https://github.com/apache/druid/pull/10290#issuecomment-716773512
>@clintropolis PTAL
Apologies for the delay. I haven't looked into upgrading Guava in a while, but I recall that there might be compatibility issues with the currently supported Hadoop version (2.8.5) if we were to upgrade. Do you know if this is still true? Otherwise we might have to hold off until we bump the supported Hadoop version to 3+, or until it can thoroughly tested to ensure that this will not cause any issues with 2.8.x.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] medb commented on pull request #10290: Upgrade Guava to 28.2-jre version
Posted by GitBox <gi...@apache.org>.
medb commented on pull request #10290:
URL: https://github.com/apache/druid/pull/10290#issuecomment-718153774
> Apologies for the delay. I haven't looked into upgrading Guava in a while, but I recall that there might be compatibility issues with the currently supported Hadoop version (2.8.5) if we were to upgrade. Do you know if this is still true? Otherwise we might have to hold off until we bump the supported Hadoop version to 3+, or until it can thoroughly tested to ensure that this will not cause any issues with 2.8.x.
You are right, not all changes are compatible with Hadoop 2.x versions. I will try to separate out changes that work with existing Guava version.
Do you have any plans to update to Hadoop 3?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] stale[bot] commented on pull request #10290: Upgrade Guava to 28.2-jre version
Posted by GitBox <gi...@apache.org>.
stale[bot] commented on pull request #10290:
URL: https://github.com/apache/druid/pull/10290#issuecomment-711078468
This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 4 weeks if no further activity occurs. If you think that's incorrect or this pull request should instead be reviewed, please simply write any comment. Even if closed, you can still revive the PR at any time or discuss it on the dev@druid.apache.org list. Thank you for your contributions.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] medb commented on pull request #10290: Upgrade Guava to 28.2-jre version
Posted by GitBox <gi...@apache.org>.
medb commented on pull request #10290:
URL: https://github.com/apache/druid/pull/10290#issuecomment-711081982
@clintropolis PTAL
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] stale[bot] commented on pull request #10290: Upgrade Guava to 28.2-jre version
Posted by GitBox <gi...@apache.org>.
stale[bot] commented on pull request #10290:
URL: https://github.com/apache/druid/pull/10290#issuecomment-711081986
This issue is no longer marked as stale.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org