You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/03/17 06:21:47 UTC

[GitHub] [spark] HyukjinKwon commented on a change in pull request #31858: [SPARK-34768][SQL] Respect the default input buffer size in Univocity

HyukjinKwon commented on a change in pull request #31858:
URL: https://github.com/apache/spark/pull/31858#discussion_r595740479



##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/csv/CSVOptions.scala
##########
@@ -166,8 +166,6 @@ class CSVOptions(
 
   val quoteAll = getBool("quoteAll", false)
 
-  val inputBufferSize = 128

Review comment:
       This controls the buffer size in the reader (https://github.com/uniVocity/univocity-parsers/blob/master/src/main/java/com/univocity/parsers/common/input/DefaultCharInputReader.java). So I think it will increase from 128 bytes to 1 MB which shouldn't be a big deal.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org