[PATCH] build/buildcheck.sh: check also autoheader

[Jani Averbach <ja...@cc.jyu.fi>]

Hi!

This very small pacth add test for autoheader. I think that this is
relevant if user set AUTOCONF, but forget set AUTOHEADER. I also add
some advertisement about those variable to error message.

The patch has been generated against version 3425.

Log message:

* build/buildcheck.sh : Add check also for autoheader, and made output
  more verbose in case that wrong version of autoconf/autoheader has been
  found.


Index: build/buildcheck.sh
===================================================================
--- build/buildcheck.sh
+++ build/buildcheck.sh Mon Oct 21 14:16:45 2002
@@ -18,10 +18,32 @@
 if test "$1" = "2" -a "$2" -lt "50" || test "$1" -lt "2"; then
   echo "buildcheck: autoconf version $ac_version found."
   echo "            You need autoconf version 2.50 or newer installed."
+  echo "            If you have sufficient autoconf installed but it is not named ''autoconf''"
+  echo "            you should set AUTOCONF variable to correct value."
   exit 1
 fi

 echo "buildcheck: autoconf version $ac_version (ok)"
+
+#--------------------------------------------------------------------------
+# autoheader 2.50 or newer
+#
+ah_version=`${AUTOHEADER:-autoheader} --version 2>/dev/null|head -1| sed -e 's/^[^0-9]*//' -e 's/[a-z]* *$//'`
+if test -z "$ah_version"; then
+  echo "buildcheck: autoheader not found."
+  echo "            You need autoheader version 2.50 or newer installed."
+  exit 1
+fi
+IFS=.; set $ah_version; IFS=' '
+if test "$1" = "2" -a "$2" -lt "50" || test "$1" -lt "2"; then
+  echo "buildcheck: autoheader version $ah_version found."
+  echo "            You need autoheader version 2.50 or newer installed."
+  echo "            If you have sufficient autoheader installed but it is not named ''autoheader''"
+  echo "            you should set AUTOHEADER variable to correct value."
+  exit 1
+fi
+
+echo "buildcheck: autoheader version $ah_version (ok)"


BR, Jani

--
Jani Averbach



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: [PATCH] build/buildcheck.sh: check also autoheader

[Jani Averbach <ja...@cc.jyu.fi>]

On Mon, 21 Oct 2002, Jani Averbach wrote:

>
> I tried install subversion to RH7.3, where autoconf 2.13 is default, so
> buildcheck.sh failed. Then I take quick look to script, and founded that I
> could set AUTOCONF variable, which I set.

Note:
There is also autoconf 2.53 installed, like autoconf-2.53.

BR, Jani

--
Jani Averbach


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: [PATCH] build/buildcheck.sh: check also autoheader

[Jani Averbach <ja...@cc.jyu.fi>]

On 21 Oct 2002, Karl Fogel wrote:

>
> Did you encounter a problem where autoheader was misinstalled, but
> autoconf itself was okay?  (I thought they got installed together...)
>

I tried install subversion to RH7.3, where autoconf 2.13 is default, so
buildcheck.sh failed. Then I take quick look to script, and founded that I
could set AUTOCONF variable, which I set. Now buildcheck ran fine, but
afterward there was an error message:
FATAL ERROR: autoheader 2.50 needed, but that however didn't stop
autogen.sh.

... and I desperately missed that fatal error message. So more confusion
followed, until I found that I have to also set AUTOHEADER.

This is the story of this patch, I feel that it won't hurt check both of
them, and to be same time little bit more verbose.  This could save
somebody's time (if she/he isn't familiar with autoconf).

BR, Jani

--
Jani Averbach


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: [PATCH] build/buildcheck.sh: check also autoheader

[Karl Fogel <kf...@newton.ch.collab.net>]

Jani Averbach <ja...@cc.jyu.fi> writes:
> This very small pacth add test for autoheader. I think that this is
> relevant if user set AUTOCONF, but forget set AUTOHEADER. I also add
> some advertisement about those variable to error message.

Did you encounter a problem where autoheader was misinstalled, but
autoconf itself was okay?  (I thought they got installed together...)

The patch itself looks okay; I'd just like to understand more what
motivates it.

Thanks,
-Karl

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org