[jira] [Commented] (MJAVADOC-497) javadoc:aggregate ignores excludePackageNames

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/MJAVADOC-497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16176342#comment-16176342 ] 

ASF GitHub Bot commented on MJAVADOC-497:
-----------------------------------------

GitHub user klaren opened a pull request:

    https://github.com/apache/maven-plugins/pull/130

    [MJAVADOC-497] javadoc:aggregate ignores excludePackageNames

    Patch to fix issue: https://issues.apache.org/jira/browse/MJAVADOC-497

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/klaren/maven-plugins MJAVADOC-497

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/maven-plugins/pull/130.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #130
    
----
commit 883143781e79992a4443300fdfd1c27b6b0c79d8
Author: Anton Klaren <an...@neotechnology.com>
Date:   2017-09-22T12:32:38Z

    MJAVADOC-497 move excluded packages to after sourcepath recalculations

----


> javadoc:aggregate ignores excludePackageNames
> ---------------------------------------------
>
>                 Key: MJAVADOC-497
>                 URL: https://issues.apache.org/jira/browse/MJAVADOC-497
>             Project: Maven Javadoc Plugin
>          Issue Type: Bug
>          Components: javadoc
>    Affects Versions: 3.0.0-M1
>            Reporter: Anton Klarén
>
> When running {{javadoc:aggregate}} and specifying {{subpackage}} and {{excludePackageNames}}, {{excludePackageNames}} is completely ignored.
> According to the code, {{excludePackageNames}} is only considered when {{sourcepath}} is set. This is however not applicable to an aggregated project, or it might but I'm not seeing it. What happens in the code is that {{sourcepath}} is derived from the found sources during aggregation, unfortunately, this happens after the excluded packages have been calculated.
> I have a patch for this that will be linked as soon as I have the issue number.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)