[jira] [Closed] (OAK-5046) Remove the old estimation OSGi setting (compaction.gainThreshold)

["Davide Giannella (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/OAK-5046?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Davide Giannella closed OAK-5046.
---------------------------------

Bulk close for 1.5.13

> Remove the old estimation OSGi setting (compaction.gainThreshold)
> -----------------------------------------------------------------
>
>                 Key: OAK-5046
>                 URL: https://issues.apache.org/jira/browse/OAK-5046
>             Project: Jackrabbit Oak
>          Issue Type: Improvement
>          Components: segment-tar
>    Affects Versions: 1.5.12
>            Reporter: Andrei Dulceanu
>            Assignee: Andrei Dulceanu
>            Priority: Minor
>              Labels: osgi-config
>             Fix For: 1.6, 1.5.13
>
>         Attachments: OAK-5046-01.patch, OAK-5046-02.patch, OAK-5046-03.patch, OAK-5046-04.patch, OAK-5046-05.patch
>
>
> Currently, there are two implementations for finding out the gain in repository size after running compaction: the old one, {{CompactionGainEstimate}} and the new one, {{SizeDeltaGcEstimation}}. Similarly, there are also two configurations for customising them, in {{SegmentNodeStoreService}}, {{compaction.gainThreshold}} and {{compaction.sizeDeltaEstimation}}.
> At the moment both of them are exposed as OSGi configurations, but only the new one should be exposed (e.g. {{compaction.sizeDeltaEstimation}}). 
> It must be evaluated whether it makes sense to keep the logic associated with the old implementation.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)