You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/04/01 04:47:21 UTC

[GitHub] [flink] sunjincheng121 commented on issue #8057: [FLINK-12028][table] Add `addColumns`,`renameColumns`, `dropColumns` …

sunjincheng121 commented on issue #8057: [FLINK-12028][table] Add `addColumns`,`renameColumns`, `dropColumns` …
URL: https://github.com/apache/flink/pull/8057#issuecomment-478434229
 
 
   Hi, @dawidwys thanks for your valuable comments.  I have updated the PR with the following changes:
   
    - remove all batch test case
    - AddColumns(replaceIfExist, ..) -> AddOrReplaceColumns(...)
    - reduce ITcase in one method
    - Some doc improvement.
   
   Thanks again for your review and offline call. I appreciate if you can have a look at this PR again, and welcome any feedback! 
   
   Best,
   Jincheng

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services