You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by "jonomorris (via GitHub)" <gi...@apache.org> on 2026/03/10 11:52:08 UTC
[PR] CAMEL-23141: update Lucene to 10.x [camel]
jonomorris opened a new pull request, #21909:
URL: https://github.com/apache/camel/pull/21909
# Description
Update Lucene to 10.x, and provide some fixes following the removal of code deprecated in the previous version.
<!--
- Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
-->
# Target
- [x] I checked that the commit is targeting the correct branch (Camel 4 uses the `main` branch)
# Tracking
- [ ] If this is a large change, bug fix, or code improvement, I checked there is a [JIRA issue](https://issues.apache.org/jira/browse/CAMEL) filed for the change (usually before you start working on it).
<!--
# *Note*: trivial changes like, typos, minor documentation fixes and other small items do not require a JIRA issue. In this case your pull request should address just this issue, without pulling in other changes.
-->
# Apache Camel coding standards and style
- [ ] I checked that each commit in the pull request has a meaningful subject line and body.
<!--
If you're unsure, you can format the pull request title like `[CAMEL-XXX] Fixes bug in camel-file component`, where you replace `CAMEL-XXX` with the appropriate JIRA issue.
-->
- [ ] I have run `mvn clean install -DskipTests` locally from root folder and I have committed all auto-generated changes.
<!--
You can run the aforementioned command in your module so that the build auto-formats your code. This will also be verified as part of the checks and your PR may be rejected if if there are uncommited changes after running `mvn clean install -DskipTests`.
You can learn more about the contribution guidelines at https://github.com/apache/camel/blob/main/CONTRIBUTING.md
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CAMEL-23141: update Lucene to 10.x [camel]
Posted by "apupier (via GitHub)" <gi...@apache.org>.
apupier commented on code in PR #21909:
URL: https://github.com/apache/camel/pull/21909#discussion_r2911304680
##########
components/camel-lucene/src/main/java/org/apache/camel/component/lucene/LuceneSearcher.java:
##########
@@ -89,7 +90,8 @@ private int doSearch(String searchPhrase, int maxNumberOfHits, int totalHitsThre
QueryParser parser = new QueryParser("contents", analyzer);
Query query = parser.parse(searchPhrase);
- TopScoreDocCollector collector = TopScoreDocCollector.create(maxNumberOfHits, totalHitsThreshold);
+ TopScoreDocCollector collector
+ = new TopScoreDocCollectorManager(maxNumberOfHits, totalHitsThreshold).newCollector();
indexSearcher.search(query, collector);
Review Comment:
to avoid using the deprecated search method, I think we should use something like:
```
TopScoreDocCollectorManager topScoreDocCollectorManager
= new TopScoreDocCollectorManager(maxNumberOfHits, totalHitsThreshold);
indexSearcher.search(query, topScoreDocCollectorManager);
TopScoreDocCollector collector = topScoreDocCollectorManager.newCollector();
hits = collector.topDocs().scoreDocs;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CAMEL-23141: update Lucene to 10.x [camel]
Posted by "jonomorris (via GitHub)" <gi...@apache.org>.
jonomorris commented on PR #21909:
URL: https://github.com/apache/camel/pull/21909#issuecomment-4038553748
@apupier, deprecated search method replaced.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CAMEL-23141: update Lucene to 10.x [camel]
Posted by "jonomorris (via GitHub)" <gi...@apache.org>.
jonomorris commented on code in PR #21909:
URL: https://github.com/apache/camel/pull/21909#discussion_r2911473094
##########
components/camel-lucene/src/main/java/org/apache/camel/component/lucene/LuceneSearcher.java:
##########
@@ -89,7 +90,8 @@ private int doSearch(String searchPhrase, int maxNumberOfHits, int totalHitsThre
QueryParser parser = new QueryParser("contents", analyzer);
Query query = parser.parse(searchPhrase);
- TopScoreDocCollector collector = TopScoreDocCollector.create(maxNumberOfHits, totalHitsThreshold);
+ TopScoreDocCollector collector
+ = new TopScoreDocCollectorManager(maxNumberOfHits, totalHitsThreshold).newCollector();
indexSearcher.search(query, collector);
Review Comment:
Yeah we can if you like. That search version looked like it was experimental in Lucene.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CAMEL-23141: update Lucene to 10.x [camel]
Posted by "apupier (via GitHub)" <gi...@apache.org>.
apupier commented on PR #21909:
URL: https://github.com/apache/camel/pull/21909#issuecomment-4039088837
@jonomorris thank you very much for your contribution
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CAMEL-23141: update Lucene to 10.x [camel]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #21909:
URL: https://github.com/apache/camel/pull/21909#issuecomment-4030832159
:star2: Thank you for your contribution to the Apache Camel project! :star2:
:robot: CI automation will test this PR automatically.
:camel: Apache Camel Committers, please review the following items:
* First-time contributors **require MANUAL approval** for the GitHub Actions to run
* You can use the command `/component-test (camel-)component-name1 (camel-)component-name2..` to request a test from the test bot although they are normally detected and executed by CI.
* You can label PRs using `build-all`, `build-dependents`, `skip-tests` and `test-dependents` to fine-tune the checks executed by this PR.
* Build and test logs are available in the summary page. **Only** [Apache Camel committers](https://camel.apache.org/community/team/#committers) have access to the summary.
:warning: Be careful when sharing logs. Review their contents before sharing them publicly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CAMEL-23141: update Lucene to 10.x [camel]
Posted by "jonomorris (via GitHub)" <gi...@apache.org>.
jonomorris commented on PR #21909:
URL: https://github.com/apache/camel/pull/21909#issuecomment-4034410599
Let me have another look tonight
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CAMEL-23141: update Lucene to 10.x [camel]
Posted by "apupier (via GitHub)" <gi...@apache.org>.
apupier merged PR #21909:
URL: https://github.com/apache/camel/pull/21909
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org