[GitHub] [superset] ktmud commented on pull request #19148: fix: TimezoneSelector is not reliably testable

[GitBox <gi...@apache.org>]

ktmud commented on pull request #19148:
URL: https://github.com/apache/superset/pull/19148#issuecomment-1067484745


   I think ideally we'd want to test both DST and non-DST so you'd need to mock both a January and June date.
   
   To fix the tests, all you have to do is simply removing [L85](https://github.com/apache/superset/blob/3a78165d13c309fc946ad52c9470b093fffbeddc/superset-frontend/src/components/TimezoneSelector/TimezoneSelector.test.tsx#L85). It was broken because `America/Adak` uses daylight saving time therefore was ranked to a lower position when timezone switched. The user input line was broken for you probably because the other changes you made.
   
   I'm not sure we need to change the component code itself. Let me see what I can do.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org