You are viewing a plain text version of this content. The canonical link for it is here.
Posted to apreq-dev@httpd.apache.org by "Philip M. Gollucci" <pg...@p6m7g8.com> on 2005/04/17 05:49:30 UTC
[PATCH] build/version_check.pl
Add Test::Inline to the prequisite list for running tests
Index: version_check.pl
===================================================================
--- version_check.pl (revision 161614)
+++ version_check.pl (working copy)
@@ -131,6 +131,9 @@
print "\n", "=" x 50, "\n";
print_prereqs
"Additional prerequisites for apreq subversion builds\n",
\%svn;
+ print "\n", "=" x 50, "\n";
+ print_prereqs
+ "Additional
prerequisites to run the perl glue test suites\n", \%test;
}
exit 0;
--
END
------------------------------------------------------
Philip M. Gollucci (pgollucci@p6m7g8.com) 301.254.5198
Consultant / http://p6m7g8.net/Resume/resume.shtml
Senior Developer / Liquidity Services, Inc.
http://www.liquidityservicesinc.com
Re: [PATCH] build/version_check.pl
Posted by Joe Schaefer <jo...@sunstarsys.com>.
"Philip M. Gollucci" <pg...@p6m7g8.com> writes:
> Joe Schaefer wrote:
>> Line wrap strikes again. Try to keep your source code lines
>> under 75 chars.
>>
> Did you want me to resubmit that ?
No, I suggest just chilling on the patches for a few days. I'm
not in a rush to release anything; IMO its more important for
this project to establish some accepted processes for managing
its section of the subversion repository. We want a quicker
turnaround when we're doing non-dev releases, and I think getting
more practice making group decisions will help make that happen.
> Interestingly the line above it with %svn is 76 chars so it
> didn't seem that much longer. I thought the standard was 78 anyway.
>
> At any rate I'll wrap at 75 in the future.
Thanks. There's no standard here, btw. It's just my experience
that 74 chars or less seems to works better for emailed patches,
because folks will occasionally want to post followup comments
on the patch itself.
--
Joe Schaefer
Re: [PATCH] build/version_check.pl
Posted by "Philip M. Gollucci" <pg...@p6m7g8.com>.
Joe Schaefer wrote:
>
> Line wrap strikes again. Try to keep your source code lines
> under 75 chars.
>
Did you want me to resubmit that ?
Interestingly the line above it with %svn is 76 chars so it
didn't seem that much longer. I thought the standard was 78 anyway.
At any rate I'll wrap at 75 in the future.
--
END
------------------------------------------------------
Philip M. Gollucci (pgollucci@p6m7g8.com) 301.254.5198
Consultant / http://p6m7g8.net/Resume/resume.shtml
Senior Developer / Liquidity Services, Inc.
http://www.liquidityservicesinc.com
Re: [PATCH] build/version_check.pl
Posted by Joe Schaefer <jo...@sunstarsys.com>.
"Philip M. Gollucci" <pg...@p6m7g8.com> writes:
> Add Test::Inline to the prequisite list for running tests
>
> Index: version_check.pl
> ===================================================================
> --- version_check.pl (revision 161614)
> +++ version_check.pl (working copy)
> @@ -131,6 +131,9 @@
> print "\n", "=" x 50, "\n";
> print_prereqs
> "Additional prerequisites for apreq subversion
> builds\n", \%svn;
> + print "\n", "=" x 50, "\n";
> + print_prereqs
> + "Additional prerequisites to
> run the perl glue test suites\n", \%test;
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Line wrap strikes again. Try to keep your source code lines
under 75 chars.
--
Joe Schaefer