You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Martin Grigorov (Reopened) (JIRA)" <ji...@apache.org> on 2011/11/30 00:19:39 UTC
[jira] [Reopened] (WICKET-3956)
(Indexed|MixedParam)HybridUrlCodingStrategy ignore interface parameter
[ https://issues.apache.org/jira/browse/WICKET-3956?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Martin Grigorov reopened WICKET-3956:
-------------------------------------
Hi Dan!
Yes, the changed expectations in the unit tests is what bothers me.
As I said I don't want to compromise 1.4.x that late in its lifetime.
Anyway, I'm reopening the ticket so someone else can take a look and fix it if this is really broken at the moment.
Isn't it possible to extend this class and fix the problem in your class ?
> (Indexed|MixedParam)HybridUrlCodingStrategy ignore interface parameter
> ----------------------------------------------------------------------
>
> Key: WICKET-3956
> URL: https://issues.apache.org/jira/browse/WICKET-3956
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.4.18
> Reporter: Dan Retzlaff
> Attachments: myproject.zip, myproject.zip, wicket-3956.patch
>
>
> Whereas BookmarkablePageRequestTargetUrlCodingStrategy looks to both the decoded parameters *and* the request parameters for an interface, HybridUrlCodingStrategy does not. This means its MixedParam and Indexed subclasses, for which not all parameters are encoded in the URL, get decoded into HybridBookmarkablePageRequestTargets instead of BookmarkableListenerInterfaceRequestTarget. In my application, this causes form submits to break.
> The attached patch modifies testStatelessHybridUrlCodingStrategy to use the MixedParamHybridUrlCodingStrategy instead of HybridUrlCodingStrategy to demonstrate the issue. It also includes a fix.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira