[jira] [Commented] (TINKERPOP-2088) Enable SourceLink for Gremlin.Net

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/TINKERPOP-2088?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16729103#comment-16729103 ] 

ASF GitHub Bot commented on TINKERPOP-2088:
-------------------------------------------

FlorianHockmann commented on pull request #1026: TINKERPOP-2088 Enable SourceLink for Gremlin.Net
URL: https://github.com/apache/tinkerpop/pull/1026
 
 
   https://issues.apache.org/jira/browse/TINKERPOP-2088
   
   This requires contributors to update to .NET Core SDK 2.1.300 or newer.
   Travis and the Docker build now use the most recent SDK 2.2.
   
   SourceLink should make it easier for users to debug Gremlin.Net within their application as they get better access to the source code of Gremlin.Net during debugging. That is why the .NET open-source library guidance recommends to enable it for libraries.
   
   The generated NuGet package includes a reference to our git repository as well as the commit that belongs to the version included in the package:
   ![tinkerpop-2088-sourcelink](https://user-images.githubusercontent.com/21224336/50451924-51b24680-0937-11e9-85b0-cca9f06774e0.jpg)
   
   I verified that the Docker build still works with `docker/build.sh`.
   
   VOTE +1
   
   NOTE: We don't need to merge this for the upcoming release, especially since we have have a code freeze (although we don't strictly follow that for GLVs). I just had some spare time to work on this, but we can also merge it after the 3.3.5 release.
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Enable SourceLink for Gremlin.Net
> ---------------------------------
>
>                 Key: TINKERPOP-2088
>                 URL: https://issues.apache.org/jira/browse/TINKERPOP-2088
>             Project: TinkerPop
>          Issue Type: Improvement
>          Components: dotnet
>            Reporter: Florian Hockmann
>            Priority: Minor
>
> SourceLink allows users to step into the sources of a library during debugging. Description [from the dotnet docs|https://docs.microsoft.com/dotnet/standard/library-guidance/sourcelink]:
> {quote}SourceLink is a technology that enables source code debugging of .NET assemblies from NuGet by developers. SourceLink executes when creating the NuGet package and embeds source control metadata inside assemblies and the package. Developers who download the package and have SourceLink enabled in Visual Studio can step into its source code. SourceLink provides source control metadata to create a great debugging experience.
> {quote}
> While the quote only mentions Visual Studio, it should also work with Rider and VS Code.
> The sources are fetched from GitHub. The NuGet package includes information about which commit was used to build the package.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)