[GitHub] [superset] hughhhh commented on a diff in pull request #20136: feat: Add Certified filter to Datasets

[GitBox <gi...@apache.org>]

hughhhh commented on code in PR #20136:
URL: https://github.com/apache/superset/pull/20136#discussion_r879776908


##########
superset/datasets/api.py:
##########
@@ -195,7 +195,11 @@ class DatasetRestApi(BaseSupersetModelRestApi):
         "owners": RelatedFieldFilter("first_name", FilterRelatedOwners),
         "database": "database_name",
     }
-    search_filters = {"sql": [DatasetIsNullOrEmptyFilter]}
+    search_filters = {
+        "sql": [DatasetIsNullOrEmptyFilter],
+        "id": [DatasetCertifiedFilter],
+    }
+    search_columns = ["id", "database", "owners", "sql", "table_name"]

Review Comment:
   if i don't set the search columns, the new filter won't be referenced. So i'm explicitly setting it here just like the other API classes



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org