You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/04/29 08:05:13 UTC

[GitHub] [beam] bullet03 opened a new pull request, #17503: Revert "[BEAM-13229] [Website] bug side nav"

bullet03 opened a new pull request, #17503:
URL: https://github.com/apache/beam/pull/17503

   Reverts apache/beam#17260
   - Ritesh's issue with arrow images not being displayed on staging is not present on the master branch after the merge. We want to revert the changes because the menu still works incorrectly.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] bullet03 commented on pull request #17503: Revert "[BEAM-13229] [Website] bug side nav"

Posted by GitBox <gi...@apache.org>.
bullet03 commented on PR #17503:
URL: https://github.com/apache/beam/pull/17503#issuecomment-1113141680

   > Reverts #17260
   > 
   > * We want to revert the changes from [BEAM-13229](https://issues.apache.org/jira/browse/BEAM-13229) because the menu still works incorrectly.
   
   Ritesh's issue with arrow images not being displayed on staging is not present on the master branch after the merge. 
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] riteshghorse commented on pull request #17503: Revert "[BEAM-13229] [Website] bug side nav"

Posted by GitBox <gi...@apache.org>.
riteshghorse commented on PR #17503:
URL: https://github.com/apache/beam/pull/17503#issuecomment-1113345449

   R: @pabloem 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] pabloem merged pull request #17503: Revert "[BEAM-13229] [Website] bug side nav"

Posted by GitBox <gi...@apache.org>.
pabloem merged PR #17503:
URL: https://github.com/apache/beam/pull/17503


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] asf-ci commented on pull request #17503: Revert "[BEAM-13229] [Website] bug side nav"

Posted by GitBox <gi...@apache.org>.
asf-ci commented on PR #17503:
URL: https://github.com/apache/beam/pull/17503#issuecomment-1113000723

   Can one of the admins verify this patch?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] asf-ci commented on pull request #17503: Revert "[BEAM-13229] [Website] bug side nav"

Posted by GitBox <gi...@apache.org>.
asf-ci commented on PR #17503:
URL: https://github.com/apache/beam/pull/17503#issuecomment-1113000725

   Can one of the admins verify this patch?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] riteshghorse commented on pull request #17503: Revert "[BEAM-13229] [Website] bug side nav"

Posted by GitBox <gi...@apache.org>.
riteshghorse commented on PR #17503:
URL: https://github.com/apache/beam/pull/17503#issuecomment-1113344235

   Verified that orange lines doesn't appear on master branch. But as mentioned by @bullet03 , the side nav doesn't scroll properly.
   
   Ex: If I'm on 10th section, the side nav still points at 6th unless I scroll on side nav explicitly.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org