[GitHub] [cloudstack] weizhouapache commented on a change in pull request #4141: [New feature] Load balancer customization (haproxy-based)

[GitBox <gi...@apache.org>]

weizhouapache commented on a change in pull request #4141:
URL: https://github.com/apache/cloudstack/pull/4141#discussion_r491943641



##########
File path: api/src/main/java/com/cloud/network/lb/LoadBalancerConfigService.java
##########
@@ -0,0 +1,40 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.  See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership.  The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License.  You may obtain a copy of the License at
+//
+//   http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied.  See the License for the
+// specific language governing permissions and limitations
+// under the License.
+package com.cloud.network.lb;

Review comment:
       > got one quarter into reviewing, so I will not pass judgement. looks good so far. We got a request on list to include this in 4.15, but as it requires a new svm template I'm not sure how realistic that is. I marked it 4.15 for now. (cc @weizhouapache @PaulAngus @rhtyd )
   
   @DaanHoogland it requires haproxy 1.8 to support HTTP2. 
   However, debian 10 already has haproxy 1.8 installed so new systemvm template is not required.
   https://packages.debian.org/buster/haproxy
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org