[jira] [Commented] (OLINGO-1003) Binary content in batch requests gets corrupted

["Christian Amend (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OLINGO-1003?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15418772#comment-15418772 ] 

Christian Amend commented on OLINGO-1003:
-----------------------------------------

Hi Frederick,

in the patch I see the adjustment you made to the test but not the fix for the issue in the BatchLineReader or BatchRequestTransformator. Could you check your patch file please? Or did I misunderstand the issue?

Best Regards,
Christian

> Binary content in batch requests gets corrupted
> -----------------------------------------------
>
>                 Key: OLINGO-1003
>                 URL: https://issues.apache.org/jira/browse/OLINGO-1003
>             Project: Olingo
>          Issue Type: Bug
>          Components: odata4-server
>    Affects Versions: (Java) V4 4.2.0
>            Reporter: Frederik Zimmer
>         Attachments: OLINGO1003-Binary-content-in-batch-requests-gets-cor.patch
>
>
> Batch requests can contain binary data e.g. for a media entity. BatchLineReader reads the binary data as a UTF-8 string and BatchRequestTransformator tries to extract the original bytes from the UTF-8 string.
> Converting arbitrary binary data into an UTF-8 string and retrieving the bytes from the UTF-8 string will not always return the original bytes the string was created from.
> Don't interpret binary data as strings.
> I have attached a fix for the testcase for binary data in BatchRequestParserTest which doesn't compare binary data but compares strings.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)