You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@orc.apache.org by "dongjoon-hyun (via GitHub)" <gi...@apache.org> on 2023/06/04 14:58:10 UTC

[GitHub] [orc] dongjoon-hyun commented on a diff in pull request #1529: ORC-1440: Check for protobuf config based module

dongjoon-hyun commented on code in PR #1529:
URL: https://github.com/apache/orc/pull/1529#discussion_r1216779558


##########
cmake_modules/FindProtobuf.cmake:
##########
@@ -26,6 +26,24 @@
 # PROTOBUF_EXECUTABLE: location of protoc
 
 
+find_package(Protobuf CONFIG)
+if(Protobuf_FOUND)

Review Comment:
   Thank you for making a PR. Could you follow the existing coding style?
   
   https://github.com/apache/orc/blob/ec2ea9c6aff8b8515452df651f08695639c18cbb/cmake_modules/FindProtobuf.cmake#L74



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org