You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@fineract.apache.org by "somasorosdpc (via GitHub)" <gi...@apache.org> on 2025/04/16 15:11:21 UTC
[PR] FINERACT-2264: Interest pause issue - Interest calculation start again in case of early repayment during interest period [fineract]
somasorosdpc opened a new pull request, #4594:
URL: https://github.com/apache/fineract/pull/4594
Interest pause issue - Interest calculation start again in case of early repayment during interest period
## Description
Describe the changes made and why they were made.
Ignore if these details are present on the associated [Apache Fineract JIRA ticket](https://issues.apache.org/jira/browse/FINERACT-2264).
## Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
- [ ] Write the commit message as per https://github.com/apache/fineract/#pull-requests
- [ ] Acknowledge that we will not review PRs that are not passing the build _("green")_ - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
- [ ] Create/update unit or integration tests for verifying the changes made.
- [ ] Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.
- [ ] Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes
- [ ] Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the developer mailing list for guidance, if required.)
FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] FINERACT-2264: Interest pause issue - Interest calculation start again in case of early repayment during interest period [fineract]
Posted by "oleksii-novikov-onix (via GitHub)" <gi...@apache.org>.
oleksii-novikov-onix commented on code in PR #4594:
URL: https://github.com/apache/fineract/pull/4594#discussion_r2051087156
##########
fineract-progressive-loan/src/main/java/org/apache/fineract/portfolio/loanproduct/calc/data/InterestPeriod.java:
##########
@@ -89,6 +89,13 @@ public static InterestPeriod withEmptyAmounts(@NotNull RepaymentPeriod repayment
zero.getMc(), false);
}
+ public static InterestPeriod withEmptyAmounts(@NotNull RepaymentPeriod repaymentPeriod, @NotNull LocalDate fromDate, LocalDate dueDate,
Review Comment:
In my opinion, using `@NotNull` here is a mistake. Jakarta validation annotations are intended for runtime validation, which does not apply in this case. For static analysis, it is better to use Spring annotations instead.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] FINERACT-2264: Interest pause issue - Interest calculation start again in case of early repayment during interest period [fineract]
Posted by "adamsaghy (via GitHub)" <gi...@apache.org>.
adamsaghy commented on code in PR #4594:
URL: https://github.com/apache/fineract/pull/4594#discussion_r2054138459
##########
fineract-progressive-loan/src/main/java/org/apache/fineract/portfolio/loanproduct/calc/data/InterestPeriod.java:
##########
@@ -89,6 +89,13 @@ public static InterestPeriod withEmptyAmounts(@NotNull RepaymentPeriod repayment
zero.getMc(), false);
}
+ public static InterestPeriod withEmptyAmounts(@NotNull RepaymentPeriod repaymentPeriod, @NotNull LocalDate fromDate, LocalDate dueDate,
Review Comment:
Agree there is some confusion around which NotNull / NonNull annotation to be used. Let me create a follow up story for this, but in the meantime we can use the proper one here (NonNull)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] FINERACT-2264: Interest pause issue - Interest calculation start again in case of early repayment during interest period [fineract]
Posted by "adamsaghy (via GitHub)" <gi...@apache.org>.
adamsaghy merged PR #4594:
URL: https://github.com/apache/fineract/pull/4594
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] FINERACT-2264: Interest pause issue - Interest calculation start again in case of early repayment during interest period [fineract]
Posted by "somasorosdpc (via GitHub)" <gi...@apache.org>.
somasorosdpc commented on code in PR #4594:
URL: https://github.com/apache/fineract/pull/4594#discussion_r2053680589
##########
fineract-progressive-loan/src/main/java/org/apache/fineract/portfolio/loanproduct/calc/data/InterestPeriod.java:
##########
@@ -89,6 +89,13 @@ public static InterestPeriod withEmptyAmounts(@NotNull RepaymentPeriod repayment
zero.getMc(), false);
}
+ public static InterestPeriod withEmptyAmounts(@NotNull RepaymentPeriod repaymentPeriod, @NotNull LocalDate fromDate, LocalDate dueDate,
Review Comment:
I've checked the whole feature of EMI calculator and I've found that we are using Jakarta validation annotations only. I'm not sure, what was the original purpose of it. I think we should start a new conversation about validation, because It looks way bigger change than a simple refactor for a feature fix.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] FINERACT-2264: Interest pause issue - Interest calculation start again in case of early repayment during interest period [fineract]
Posted by "adamsaghy (via GitHub)" <gi...@apache.org>.
adamsaghy commented on code in PR #4594:
URL: https://github.com/apache/fineract/pull/4594#discussion_r2054138459
##########
fineract-progressive-loan/src/main/java/org/apache/fineract/portfolio/loanproduct/calc/data/InterestPeriod.java:
##########
@@ -89,6 +89,13 @@ public static InterestPeriod withEmptyAmounts(@NotNull RepaymentPeriod repayment
zero.getMc(), false);
}
+ public static InterestPeriod withEmptyAmounts(@NotNull RepaymentPeriod repaymentPeriod, @NotNull LocalDate fromDate, LocalDate dueDate,
Review Comment:
Agree there is some confusion around which NotNull / NonNull annotation to be used. Let me create a follow up story for this, but in the meantime we can use the proper one here (NonNull)https://issues.apache.org/jira/browse/FINERACT-2267
##########
fineract-progressive-loan/src/main/java/org/apache/fineract/portfolio/loanproduct/calc/data/InterestPeriod.java:
##########
@@ -89,6 +89,13 @@ public static InterestPeriod withEmptyAmounts(@NotNull RepaymentPeriod repayment
zero.getMc(), false);
}
+ public static InterestPeriod withEmptyAmounts(@NotNull RepaymentPeriod repaymentPeriod, @NotNull LocalDate fromDate, LocalDate dueDate,
Review Comment:
Agree there is some confusion around which NotNull / NonNull annotation to be used. Let me create a follow up story for this, but in the meantime we can use the proper one here (NonNull) https://issues.apache.org/jira/browse/FINERACT-2267
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org