You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@syncope.apache.org by GitBox <gi...@apache.org> on 2022/11/11 10:24:36 UTC
[GitHub] [syncope] mmoayyed opened a new pull request, #390: SYNCOPE-1709: Persist Jobs' current status in the database to support multi-node deployments
mmoayyed opened a new pull request, #390:
URL: https://github.com/apache/syncope/pull/390
## JIRA
https://issues.apache.org/jira/browse/SYNCOPE-1709
I have tested this quite a lot. There are minor issues with the UI but I think most of what I found was the result of me introducing delays into the job execution. I have also included an extra unit test to ensure job status can be stored, found, and removed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@syncope.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [syncope] ilgrosso commented on a diff in pull request #390: SYNCOPE-1709: Persist Jobs' current status in the database to support multi-node deployments
Posted by GitBox <gi...@apache.org>.
ilgrosso commented on code in PR #390:
URL: https://github.com/apache/syncope/pull/390#discussion_r1020137794
##########
core/provisioning-java/src/main/java/org/apache/syncope/core/provisioning/java/job/report/UserReportlet.java:
##########
@@ -363,11 +362,20 @@ protected int count() {
AnyTypeKind.USER);
}
+ private void sleep() {
Review Comment:
...but also the calls to this method shall be removed altogether ;-)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@syncope.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [syncope] mmoayyed merged pull request #390: SYNCOPE-1709: Persist Jobs' current status in the database to support multi-node deployments
Posted by GitBox <gi...@apache.org>.
mmoayyed merged PR #390:
URL: https://github.com/apache/syncope/pull/390
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@syncope.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [syncope] ilgrosso commented on a diff in pull request #390: SYNCOPE-1709: Persist Jobs' current status in the database to support multi-node deployments
Posted by GitBox <gi...@apache.org>.
ilgrosso commented on code in PR #390:
URL: https://github.com/apache/syncope/pull/390#discussion_r1020090342
##########
core/idrepo/logic/src/main/java/org/apache/syncope/core/logic/ReportLogic.java:
##########
@@ -272,8 +274,8 @@ public void exportExecutionResult(
final ReportExecExportFormat format) {
// streaming SAX handler from a compressed byte array stream
- try (ByteArrayInputStream bais = new ByteArrayInputStream(reportExec.getExecResult());
- ZipInputStream zis = new ZipInputStream(bais)) {
+ try ( ByteArrayInputStream bais = new ByteArrayInputStream(reportExec.getExecResult()); ZipInputStream zis =
Review Comment:
Please revert this formatting-only change.
This will also break checkstyle AFAICT.
##########
core/provisioning-java/src/main/java/org/apache/syncope/core/provisioning/java/ProvisioningContext.java:
##########
@@ -416,7 +434,7 @@ protected Transport connectTransport() throws MessagingException {
if (provisioningProperties.getSmtp().isDebug()) {
session = mailSender.getSession();
session.setDebug(true);
- try (LogOutputStream los = new LogOutputStream(LOG)) {
+ try ( LogOutputStream los = new LogOutputStream(LOG)) {
Review Comment:
Please revert this formatting-only change.
It will also break checkstyle AFAICT.
##########
core/provisioning-java/src/main/java/org/apache/syncope/core/provisioning/java/job/report/UserReportlet.java:
##########
@@ -363,11 +362,20 @@ protected int count() {
AnyTypeKind.USER);
}
+ private void sleep() {
Review Comment:
This method must be removed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@syncope.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [syncope] ilgrosso commented on pull request #390: SYNCOPE-1709: Persist Jobs' current status in the database to support multi-node deployments
Posted by GitBox <gi...@apache.org>.
ilgrosso commented on PR #390:
URL: https://github.com/apache/syncope/pull/390#issuecomment-1311768516
@mmoayyed one checkstyle issue left:
```
Error: src\test\java\org\apache\syncope\core\provisioning\java\job\JobStatusUpdaterTest.java:[30,1] (imports) ImportOrder: Wrong order for 'org.junit.jupiter.api.Assertions.assertNotNull' import.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@syncope.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org