You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@poi.apache.org by on...@apache.org on 2016/11/02 16:37:12 UTC
svn commit: r1767728 - in /poi/trunk/src:
java/org/apache/poi/ss/formula/FormulaShifter.java
testcases/org/apache/poi/ss/formula/TestFormulaShifter.java
Author: onealj
Date: Wed Nov 2 16:37:12 2016
New Revision: 1767728
URL: http://svn.apache.org/viewvc?rev=1767728&view=rev
Log:
bug 60331: remove deprecated FormulaShifter.createForRowShift(). Require SpreadsheetVersion.
Modified:
poi/trunk/src/java/org/apache/poi/ss/formula/FormulaShifter.java
poi/trunk/src/testcases/org/apache/poi/ss/formula/TestFormulaShifter.java
Modified: poi/trunk/src/java/org/apache/poi/ss/formula/FormulaShifter.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/java/org/apache/poi/ss/formula/FormulaShifter.java?rev=1767728&r1=1767727&r2=1767728&view=diff
==============================================================================
--- poi/trunk/src/java/org/apache/poi/ss/formula/FormulaShifter.java (original)
+++ poi/trunk/src/java/org/apache/poi/ss/formula/FormulaShifter.java Wed Nov 2 16:37:12 2016
@@ -105,21 +105,6 @@ public final class FormulaShifter {
_dstSheetIndex = dstSheetIndex;
_mode = ShiftMode.SheetMove;
}
-
- /**
- * @deprecated As of 3.14 beta 1 (November 2015), replaced by {@link #createForRowShift(int, String, int, int, int, SpreadsheetVersion)}
- *
- * @param externSheetIndex
- * @param sheetName
- * @param firstMovedRowIndex
- * @param lastMovedRowIndex
- * @param numberOfRowsToMove
- * @return FormulaShifter object that can be passed to a RowShifter to modify formulas.
- */
- @Deprecated
- public static FormulaShifter createForRowShift(int externSheetIndex, String sheetName, int firstMovedRowIndex, int lastMovedRowIndex, int numberOfRowsToMove) {
- return createForRowShift(externSheetIndex, sheetName, firstMovedRowIndex, lastMovedRowIndex, numberOfRowsToMove, SpreadsheetVersion.EXCEL97);
- }
public static FormulaShifter createForRowShift(int externSheetIndex, String sheetName, int firstMovedRowIndex, int lastMovedRowIndex, int numberOfRowsToMove,
SpreadsheetVersion version) {
Modified: poi/trunk/src/testcases/org/apache/poi/ss/formula/TestFormulaShifter.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/ss/formula/TestFormulaShifter.java?rev=1767728&r1=1767727&r2=1767728&view=diff
==============================================================================
--- poi/trunk/src/testcases/org/apache/poi/ss/formula/TestFormulaShifter.java (original)
+++ poi/trunk/src/testcases/org/apache/poi/ss/formula/TestFormulaShifter.java Wed Nov 2 16:37:12 2016
@@ -276,9 +276,8 @@ public final class TestFormulaShifter {
}
@Test
- @SuppressWarnings("deprecation")
public void testConstructor() {
- assertNotNull(FormulaShifter.createForRowShift(1, "name", 1, 2, 2));
+ assertNotNull(FormulaShifter.createForRowShift(1, "name", 1, 2, 2, SpreadsheetVersion.EXCEL97));
}
@Test
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@poi.apache.org
For additional commands, e-mail: commits-help@poi.apache.org