You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/11/15 13:05:00 UTC
[jira] [Commented] (BEAM-3194) Support annotating that a DoFn
requires stable / deterministic input for reply/retry
[ https://issues.apache.org/jira/browse/BEAM-3194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16253418#comment-16253418 ]
ASF GitHub Bot commented on BEAM-3194:
--------------------------------------
GitHub user kennknowles opened a pull request:
https://github.com/apache/beam/pull/4135
[BEAM-3194] Add @RequiresStableInput annotation
Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/projects/BEAM/issues/) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
- [ ] Each commit in the pull request should have a meaningful subject line and body.
- [ ] Format the pull request title like `[BEAM-XXX] Fixes bug in ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA issue.
- [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [ ] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
---
This is a quick mock up of the very basics of the Java infrastructure for this annotation. I did not plug in the annotation to any runner. We can bikeshed on the name.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kennknowles/beam RequiresStableInput
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/beam/pull/4135.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #4135
----
commit 25b9ac452a7156a8b34023a3a9f761f4d2313bef
Author: Kenneth Knowles <kl...@google.com>
Date: 2017-11-15T12:55:34Z
Add @RequiresStableInput annotation
----
> Support annotating that a DoFn requires stable / deterministic input for reply/retry
> ------------------------------------------------------------------------------------
>
> Key: BEAM-3194
> URL: https://issues.apache.org/jira/browse/BEAM-3194
> Project: Beam
> Issue Type: New Feature
> Components: beam-model
> Reporter: Kenneth Knowles
> Assignee: Kenneth Knowles
>
> See the thread: https://lists.apache.org/thread.html/5fd81ce371aeaf642665348f8e6940e308e04275dd7072f380f9f945@%3Cdev.beam.apache.org%3E
> We need this in order to have truly cross-runner end-to-end exactly once via replay + idempotence.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)