You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by "Fine0830 (via GitHub)" <gi...@apache.org> on 2023/02/14 05:29:32 UTC
[GitHub] [skywalking-booster-ui] Fine0830 opened a new pull request, #233: refactor: optimize the attached events visualization in the trace widget
Fine0830 opened a new pull request, #233:
URL: https://github.com/apache/skywalking-booster-ui/pull/233
Optimize the attached events visualization in the trace widget.
Signed-off-by: Qiuxia Fan <qi...@apache.org>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-booster-ui] wu-sheng commented on pull request #233: refactor: optimize the attached events visualization in the trace widget
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on PR #233:
URL: https://github.com/apache/skywalking-booster-ui/pull/233#issuecomment-1429309569
Yes, the right part of trace view only.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-booster-ui] mrproliu commented on pull request #233: refactor: optimize the attached events visualization in the trace widget
Posted by "mrproliu (via GitHub)" <gi...@apache.org>.
mrproliu commented on PR #233:
URL: https://github.com/apache/skywalking-booster-ui/pull/233#issuecomment-1429268520
> Trace graph?
We only need the style on the right side of the trace.
> The events data is not a tree structure.
Yes, the events are only a list. we only need the start/end time and duration, so it doesn't matter if the events are tree or list structure.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-booster-ui] mrproliu commented on pull request #233: refactor: optimize the attached events visualization in the trace widget
Posted by "mrproliu (via GitHub)" <gi...@apache.org>.
mrproliu commented on PR #233:
URL: https://github.com/apache/skywalking-booster-ui/pull/233#issuecomment-1429223671
This looks great. I have two suggestions:
1. Can we change the time view on the right to match the view in the trace, so that users can easily see the start and end times of events and understand the relationships between events?
2. The order of the events should be sorted by ascending.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-booster-ui] mrproliu commented on pull request #233: refactor: optimize the attached events visualization in the trace widget
Posted by "mrproliu (via GitHub)" <gi...@apache.org>.
mrproliu commented on PR #233:
URL: https://github.com/apache/skywalking-booster-ui/pull/233#issuecomment-1429255175
I think he means use that style, rather han moving in to trace page.
> Yes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-booster-ui] Fine0830 commented on pull request #233: refactor: optimize the attached events visualization in the trace widget
Posted by "Fine0830 (via GitHub)" <gi...@apache.org>.
Fine0830 commented on PR #233:
URL: https://github.com/apache/skywalking-booster-ui/pull/233#issuecomment-1429242692
> This looks great. I have two suggestions:
>
> 1. Can we change the time view on the right to match the view in the trace, so that users can easily see the start and end times of events and understand the relationships between events?
Do you mean to move parts of the whole events to the trace view?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-booster-ui] wu-sheng commented on pull request #233: refactor: optimize the attached events visualization in the trace widget
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on PR #233:
URL: https://github.com/apache/skywalking-booster-ui/pull/233#issuecomment-1429249692
I think he means use that style, rather han moving in to trace page.
The key is showing the duration with order.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-booster-ui] Fine0830 commented on pull request #233: refactor: optimize the attached events visualization in the trace widget
Posted by "Fine0830 (via GitHub)" <gi...@apache.org>.
Fine0830 commented on PR #233:
URL: https://github.com/apache/skywalking-booster-ui/pull/233#issuecomment-1429261511
Trace graph? The events data is not a tree structure.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-booster-ui] Fine0830 closed pull request #233: refactor: optimize the attached events visualization in the trace widget
Posted by "Fine0830 (via GitHub)" <gi...@apache.org>.
Fine0830 closed pull request #233: refactor: optimize the attached events visualization in the trace widget
URL: https://github.com/apache/skywalking-booster-ui/pull/233
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org