You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Mehul Parikh <me...@freestoneinfotech.com> on 2017/04/03 10:31:30 UTC
Re: Review Request 58104: RangerUI: Escape of policy condition text
entered in the policy form.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58104/#review170846
-----------------------------------------------------------
Ship it!
Ship It!
- Mehul Parikh
On March 31, 2017, 11:15 a.m., Nitin Galave wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58104/
> -----------------------------------------------------------
>
> (Updated March 31, 2017, 11:15 a.m.)
>
>
> Review request for ranger, Gautam Borad, Madhan Neethiraj, Mehul Parikh, Pradeep Agrawal, and Velmurugan Periasamy.
>
>
> Bugs: RANGER-1484
> https://issues.apache.org/jira/browse/RANGER-1484
>
>
> Repository: ranger
>
>
> Description
> -------
>
> The text entered in policy condition UI comes back with escape characters after saving the policy.
>
> For example:
> 1.create policy with policy condition as \u201ctag.attributes['type']=='ccn'\u201d .
> 2.Now open that policy in edit mode you will see policy condition
> becomes "tag.attributes['type']=='ccn'".
>
> Another issue is that UI displays policy conditions that don\u2019t have any value.Only the condition edit popup would list all the conditions; the policy view would only list the conditions that have non-empty value.
>
>
> Diffs
> -----
>
> security-admin/src/main/webapp/scripts/modules/XAOverrides.js 1e2b553
> security-admin/src/main/webapp/scripts/views/policies/PermissionList.js 2ac494e
>
>
> Diff: https://reviews.apache.org/r/58104/diff/1/
>
>
> Testing
> -------
>
> Verified : Text entered in policy condition come back as it is after saving policy.
> Tested with following characters : ~`!@#$%^&*()-_+={}[]:;"'<,>.?/
>
> Verified : UI only displays policy conditions name and value which has non-empty values.
>
>
> Thanks,
>
> Nitin Galave
>
>