You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/01/30 02:34:55 UTC
[GitHub] [incubator-nuttx-apps] masayuki2009 opened a new pull request #990: import: Make.defs: Fix 'make import' for CONFIG_BUILD_KERNEL=y
masayuki2009 opened a new pull request #990:
URL: https://github.com/apache/incubator-nuttx-apps/pull/990
## Summary
- I noticed that 'make import' failed due to recent changes in nuttx
- This commit fixes this issue by adding logic for -lm
## Impact
- CONFIG_BUILD_KERNEL=y only
## Testing
- Build (mkimport, make import) with sama5d4-ek:knsh
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] masayuki2009 commented on a change in pull request #990: import: Make.defs: Fix 'make import' for CONFIG_BUILD_KERNEL=y
Posted by GitBox <gi...@apache.org>.
masayuki2009 commented on a change in pull request #990:
URL: https://github.com/apache/incubator-nuttx-apps/pull/990#discussion_r795132832
##########
File path: import/Make.defs
##########
@@ -77,7 +77,14 @@ endif
# Link with user libraries
ifeq ($(CONFIG_BUILD_KERNEL),y)
- LDLIBS = -lapps -lxx -lmm -lc -lm -lproxies
+ LDLIBS = -lapps -lxx -lmm -lc -lproxies
+ifneq ($(CONFIG_LIBM),y)
+ LIBM = ${shell "$(CC)" $(ARCHCPUFLAGS) -print-file-name=libm.a}
+ifneq ($(LIBM),)
Review comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] masayuki2009 commented on pull request #990: import: Make.defs: Fix 'make import' for CONFIG_BUILD_KERNEL=y
Posted by GitBox <gi...@apache.org>.
masayuki2009 commented on pull request #990:
URL: https://github.com/apache/incubator-nuttx-apps/pull/990#issuecomment-1025054289
See https://github.com/apache/incubator-nuttx/pull/5371 as well
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] pkarashchenko commented on a change in pull request #990: import: Make.defs: Fix 'make import' for CONFIG_BUILD_KERNEL=y
Posted by GitBox <gi...@apache.org>.
pkarashchenko commented on a change in pull request #990:
URL: https://github.com/apache/incubator-nuttx-apps/pull/990#discussion_r795131825
##########
File path: import/Make.defs
##########
@@ -77,7 +77,14 @@ endif
# Link with user libraries
ifeq ($(CONFIG_BUILD_KERNEL),y)
- LDLIBS = -lapps -lxx -lmm -lc -lm -lproxies
+ LDLIBS = -lapps -lxx -lmm -lc -lproxies
+ifneq ($(CONFIG_LIBM),y)
+ LIBM = ${shell "$(CC)" $(ARCHCPUFLAGS) -print-file-name=libm.a}
+ifneq ($(LIBM),)
Review comment:
Or use wildcard above
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] xiaoxiang781216 merged pull request #990: import: Make.defs: Fix 'make import' for CONFIG_BUILD_KERNEL=y
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 merged pull request #990:
URL: https://github.com/apache/incubator-nuttx-apps/pull/990
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] pkarashchenko commented on a change in pull request #990: import: Make.defs: Fix 'make import' for CONFIG_BUILD_KERNEL=y
Posted by GitBox <gi...@apache.org>.
pkarashchenko commented on a change in pull request #990:
URL: https://github.com/apache/incubator-nuttx-apps/pull/990#discussion_r795131034
##########
File path: import/Make.defs
##########
@@ -77,7 +77,14 @@ endif
# Link with user libraries
ifeq ($(CONFIG_BUILD_KERNEL),y)
- LDLIBS = -lapps -lxx -lmm -lc -lm -lproxies
+ LDLIBS = -lapps -lxx -lmm -lc -lproxies
+ifneq ($(CONFIG_LIBM),y)
+ LIBM = ${shell "$(CC)" $(ARCHCPUFLAGS) -print-file-name=libm.a}
+ifneq ($(LIBM),)
Review comment:
```suggestion
ifneq ($(LIBM),".")
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on a change in pull request #990: import: Make.defs: Fix 'make import' for CONFIG_BUILD_KERNEL=y
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #990:
URL: https://github.com/apache/incubator-nuttx-apps/pull/990#discussion_r795136209
##########
File path: import/Make.defs
##########
@@ -77,7 +77,14 @@ endif
# Link with user libraries
ifeq ($(CONFIG_BUILD_KERNEL),y)
- LDLIBS = -lapps -lxx -lmm -lc -lm -lproxies
+ LDLIBS = -lapps -lxx -lmm -lc -lproxies
+ifneq ($(CONFIG_LIBM),y)
+ LIBM = ${shell "$(CC)" $(ARCHCPUFLAGS) -print-file-name=libm.a}
+ifneq ($(LIBM),)
Review comment:
libgcc use empty string at line 94:
```
ifneq ($(LIBGCC),)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] pkarashchenko commented on a change in pull request #990: import: Make.defs: Fix 'make import' for CONFIG_BUILD_KERNEL=y
Posted by GitBox <gi...@apache.org>.
pkarashchenko commented on a change in pull request #990:
URL: https://github.com/apache/incubator-nuttx-apps/pull/990#discussion_r795131497
##########
File path: import/Make.defs
##########
@@ -77,7 +77,14 @@ endif
# Link with user libraries
ifeq ($(CONFIG_BUILD_KERNEL),y)
- LDLIBS = -lapps -lxx -lmm -lc -lm -lproxies
+ LDLIBS = -lapps -lxx -lmm -lc -lproxies
+ifneq ($(CONFIG_LIBM),y)
+ LIBM = ${shell "$(CC)" $(ARCHCPUFLAGS) -print-file-name=libm.a}
+ifneq ($(LIBM),)
Review comment:
```suggestion
ifneq ($(LIBM),".")
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] pkarashchenko commented on a change in pull request #990: import: Make.defs: Fix 'make import' for CONFIG_BUILD_KERNEL=y
Posted by GitBox <gi...@apache.org>.
pkarashchenko commented on a change in pull request #990:
URL: https://github.com/apache/incubator-nuttx-apps/pull/990#discussion_r795131034
##########
File path: import/Make.defs
##########
@@ -77,7 +77,14 @@ endif
# Link with user libraries
ifeq ($(CONFIG_BUILD_KERNEL),y)
- LDLIBS = -lapps -lxx -lmm -lc -lm -lproxies
+ LDLIBS = -lapps -lxx -lmm -lc -lproxies
+ifneq ($(CONFIG_LIBM),y)
+ LIBM = ${shell "$(CC)" $(ARCHCPUFLAGS) -print-file-name=libm.a}
+ifneq ($(LIBM),)
Review comment:
```suggestion
ifneq ($(LIBM),".")
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] masayuki2009 commented on a change in pull request #990: import: Make.defs: Fix 'make import' for CONFIG_BUILD_KERNEL=y
Posted by GitBox <gi...@apache.org>.
masayuki2009 commented on a change in pull request #990:
URL: https://github.com/apache/incubator-nuttx-apps/pull/990#discussion_r795132784
##########
File path: import/Make.defs
##########
@@ -77,7 +77,14 @@ endif
# Link with user libraries
ifeq ($(CONFIG_BUILD_KERNEL),y)
- LDLIBS = -lapps -lxx -lmm -lc -lm -lproxies
+ LDLIBS = -lapps -lxx -lmm -lc -lproxies
+ifneq ($(CONFIG_LIBM),y)
+ LIBM = ${shell "$(CC)" $(ARCHCPUFLAGS) -print-file-name=libm.a}
Review comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] masayuki2009 commented on a change in pull request #990: import: Make.defs: Fix 'make import' for CONFIG_BUILD_KERNEL=y
Posted by GitBox <gi...@apache.org>.
masayuki2009 commented on a change in pull request #990:
URL: https://github.com/apache/incubator-nuttx-apps/pull/990#discussion_r795137181
##########
File path: import/Make.defs
##########
@@ -77,7 +77,14 @@ endif
# Link with user libraries
ifeq ($(CONFIG_BUILD_KERNEL),y)
- LDLIBS = -lapps -lxx -lmm -lc -lm -lproxies
+ LDLIBS = -lapps -lxx -lmm -lc -lproxies
+ifneq ($(CONFIG_LIBM),y)
+ LIBM = ${shell "$(CC)" $(ARCHCPUFLAGS) -print-file-name=libm.a}
+ifneq ($(LIBM),)
Review comment:
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] pkarashchenko commented on a change in pull request #990: import: Make.defs: Fix 'make import' for CONFIG_BUILD_KERNEL=y
Posted by GitBox <gi...@apache.org>.
pkarashchenko commented on a change in pull request #990:
URL: https://github.com/apache/incubator-nuttx-apps/pull/990#discussion_r795131161
##########
File path: import/Make.defs
##########
@@ -77,7 +77,14 @@ endif
# Link with user libraries
ifeq ($(CONFIG_BUILD_KERNEL),y)
- LDLIBS = -lapps -lxx -lmm -lc -lm -lproxies
+ LDLIBS = -lapps -lxx -lmm -lc -lproxies
+ifneq ($(CONFIG_LIBM),y)
+ LIBM = ${shell "$(CC)" $(ARCHCPUFLAGS) -print-file-name=libm.a}
Review comment:
```suggestion
LIBM = ${shell "$(CC)" $(ARCHCPUFLAGS) --print-file-name=libm.a}
```
Here and below. This is just to keep the same style as in main OS repo
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] pkarashchenko commented on a change in pull request #990: import: Make.defs: Fix 'make import' for CONFIG_BUILD_KERNEL=y
Posted by GitBox <gi...@apache.org>.
pkarashchenko commented on a change in pull request #990:
URL: https://github.com/apache/incubator-nuttx-apps/pull/990#discussion_r795131825
##########
File path: import/Make.defs
##########
@@ -77,7 +77,14 @@ endif
# Link with user libraries
ifeq ($(CONFIG_BUILD_KERNEL),y)
- LDLIBS = -lapps -lxx -lmm -lc -lm -lproxies
+ LDLIBS = -lapps -lxx -lmm -lc -lproxies
+ifneq ($(CONFIG_LIBM),y)
+ LIBM = ${shell "$(CC)" $(ARCHCPUFLAGS) -print-file-name=libm.a}
+ifneq ($(LIBM),)
Review comment:
Or use `wildcard` above in `LIBM =`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org