You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2020/02/28 20:12:49 UTC

[GitHub] [druid] AlexanderSaydakov opened a new pull request #9436: added number of bins parameter

AlexanderSaydakov opened a new pull request #9436: added number of bins parameter
URL: https://github.com/apache/druid/pull/9436
 
 
   ### Description
   
   This is to support an alternative way of obtaining a histogram from a Quantiles Sketch using the DoublesSketchToHistogramPostAggregator. The parameter "splitPoints" was made optional, and another parameter "numBins" was added. The new parameter is optional as well, but it has a default of 10. Therefore if both parameters are omitted, the post agg must produce a histogram with 10 equally-spaced bins between min and max values in the sketch.
   
   I am not familiar with SQL adaptors, so I did not add this feature there.
   
   - [x ] added documentation for new or modified features or behaviors.
   - [x ] added unit tests or modified existing tests to cover new code paths.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org


[GitHub] [druid] gianm commented on issue #9436: added number of bins parameter

Posted by GitBox <gi...@apache.org>.
gianm commented on issue #9436: added number of bins parameter
URL: https://github.com/apache/druid/pull/9436#issuecomment-592754972
 
 
   Hmm, I'm not sure how you'd want to adapt this into SQL anyway. Return a string that represents the histogram, maybe?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org


[GitHub] [druid] AlexanderSaydakov commented on issue #9436: added number of bins parameter

Posted by GitBox <gi...@apache.org>.
AlexanderSaydakov commented on issue #9436: added number of bins parameter
URL: https://github.com/apache/druid/pull/9436#issuecomment-592762009
 
 
   There is some way currently, but using the split points. The result must be an array of values that represent bins.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org