You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2022/02/10 09:44:31 UTC

[GitHub] [apisix] leslie-tsang commented on a change in pull request #6281: chore: compresses the redis lua script in limit-count

leslie-tsang commented on a change in pull request #6281:
URL: https://github.com/apache/apisix/pull/6281#discussion_r803482495



##########
File path: apisix/plugins/limit-count/limit-count-redis-cluster.lua
##########
@@ -37,6 +38,10 @@ local script = [=[
     return redis.call('incrby', KEYS[1], -1)
 ]=]
 
+--- compact the redis lua script
+script = string.gsub(script, "    ", "")

Review comment:
       Yes for sure, I'm wondering where it would be more appropriate to put it. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org