You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Xi Wang <xw...@hortonworks.com> on 2017/01/05 22:18:26 UTC
Review Request 55233: Improve and Fix "Hosts page" after new
guidelines
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55233/
-----------------------------------------------------------
Review request for Ambari, Jaimin Jetly, Richard Zang, Vivek Ratnavel Subramanian, and Yusaku Sako.
Bugs: AMBARI-19313
https://issues.apache.org/jira/browse/AMBARI-19313
Repository: ambari
Description
-------
Hosts filter:
1. Not aligned with Actions button.
2. Filter dropdown menu, all host filter texts should be same font family as other texts
3. Remove icon has shadow, should not
Hosts table:
4. Text in every table row was not centered.
Diffs
-----
ambari-web/app/styles/application.less 7d18cf5
Diff: https://reviews.apache.org/r/55233/diff/
Testing
-------
19976 passing (20s)
153 pending
Thanks,
Xi Wang
Re: Review Request 55233: Improve and Fix "Hosts page" after new
guidelines
Posted by Jaimin Jetly <ja...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55233/#review160643
-----------------------------------------------------------
Ship it!
Ship It!
- Jaimin Jetly
On Jan. 5, 2017, 10:18 p.m., Xi Wang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55233/
> -----------------------------------------------------------
>
> (Updated Jan. 5, 2017, 10:18 p.m.)
>
>
> Review request for Ambari, Jaimin Jetly, Richard Zang, Vivek Ratnavel Subramanian, and Yusaku Sako.
>
>
> Bugs: AMBARI-19313
> https://issues.apache.org/jira/browse/AMBARI-19313
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Hosts filter:
> 1. Not aligned with Actions button.
> 2. Filter dropdown menu, all host filter texts should be same font family as other texts
> 3. Remove icon has shadow, should not
>
> Hosts table:
> 4. Text in every table row was not centered.
>
>
> Diffs
> -----
>
> ambari-web/app/styles/application.less 7d18cf5
>
> Diff: https://reviews.apache.org/r/55233/diff/
>
>
> Testing
> -------
>
> 19976 passing (20s)
> 153 pending
>
>
> Thanks,
>
> Xi Wang
>
>
Re: Review Request 55233: Improve and Fix "Hosts page" after new
guidelines
Posted by Vivek Ratnavel Subramanian <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55233/#review160645
-----------------------------------------------------------
Ship it!
Ship It!
- Vivek Ratnavel Subramanian
On Jan. 5, 2017, 10:18 p.m., Xi Wang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55233/
> -----------------------------------------------------------
>
> (Updated Jan. 5, 2017, 10:18 p.m.)
>
>
> Review request for Ambari, Jaimin Jetly, Richard Zang, Vivek Ratnavel Subramanian, and Yusaku Sako.
>
>
> Bugs: AMBARI-19313
> https://issues.apache.org/jira/browse/AMBARI-19313
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Hosts filter:
> 1. Not aligned with Actions button.
> 2. Filter dropdown menu, all host filter texts should be same font family as other texts
> 3. Remove icon has shadow, should not
>
> Hosts table:
> 4. Text in every table row was not centered.
>
>
> Diffs
> -----
>
> ambari-web/app/styles/application.less 7d18cf5
>
> Diff: https://reviews.apache.org/r/55233/diff/
>
>
> Testing
> -------
>
> 19976 passing (20s)
> 153 pending
>
>
> Thanks,
>
> Xi Wang
>
>