You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/03/30 18:21:15 UTC

[GitHub] [airflow] mik-laj commented on a change in pull request #8010: Add more refactor steps for providers.google

mik-laj commented on a change in pull request #8010: Add more refactor steps for providers.google
URL: https://github.com/apache/airflow/pull/8010#discussion_r400399871
 
 

 ##########
 File path: backport_packages/setup_backport_packages.py
 ##########
 @@ -243,10 +257,18 @@ def _remover(node: LN, capture: Capture, filename: Filename) -> None:
         .modify(add_provide_context_to_python_operator)
     )
 
+    # Remove new class
     remove_class(qry, "GKEStartPodOperator")
 
     qry.execute(write=True, silent=False, interactive=False)
 
+    # Add old import to GKE
+    gke_path = os.path.join(
+        dirname(__file__), "airflow", "providers", "google", "cloud", "operators", "kubernetes_engine.py"
+    )
+    with open(gke_path, "a") as f:
+        f.writelines(["", "from airflow.contrib.operators.gcp_container_operator import GKEPodOperator"])
 
 Review comment:
   Should we remove this file?
   https://github.com/apache/airflow/blob/50ee275a4090063df6b91cd9162dae32f8cbc4e0/airflow/providers/google/cloud/example_dags/example_kubernetes_engine_setup.py

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services