You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2022/04/07 12:31:27 UTC
[GitHub] [superset] zhaoyongjie opened a new pull request, #19587: Cleanup asunknown
zhaoyongjie opened a new pull request, #19587:
URL: https://github.com/apache/superset/pull/19587
### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
Clean up _as unknown_ after monorepo
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
### TESTING INSTRUCTIONS
<!--- Required! What steps can be taken to manually verify the changes? -->
Pass all CI
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] zhaoyongjie commented on a diff in pull request #19587: chore: cleanup as unknown conversion
Posted by GitBox <gi...@apache.org>.
zhaoyongjie commented on code in PR #19587:
URL: https://github.com/apache/superset/pull/19587#discussion_r845762914
##########
superset-frontend/packages/superset-ui-core/src/color/utils.ts:
##########
@@ -75,7 +75,16 @@ export function getAnalogousColors(colors: string[], results: number) {
}
export function addAlpha(color: string, opacity: number): string {
- // coerce values so ti is between 0 and 1.
- const rounded = Math.round(Math.min(Math.max(opacity || 1, 0), 1) * 255);
- return color + rounded.toString(16).toUpperCase();
+ // opacity value should be between 0 and 1.
+ if (opacity > 1 || opacity < 0) {
+ throw new Error(
+ `The alpha channel should between 0 and 1, but got: ${opacity}`,
+ );
+ }
+ // the alpha value is between 00 - FF
+ const alpha = `0${Math.round(opacity * 255)
+ .toString(16)
+ .toUpperCase()}`.slice(-2);
+
+ return `${color}${alpha}`;
Review Comment:
bycatch: fix codes coverage.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] villebro commented on a diff in pull request #19587: chore: cleanup as unknown conversion
Posted by GitBox <gi...@apache.org>.
villebro commented on code in PR #19587:
URL: https://github.com/apache/superset/pull/19587#discussion_r845879275
##########
superset-frontend/packages/superset-ui-core/test/query/buildQueryObject.test.ts:
##########
@@ -285,7 +285,8 @@ describe('buildQueryObject', () => {
datasource: '5__table',
granularity_sqla: 'ds',
viz_type: 'table',
- url_params: null as unknown as undefined,
+ // @ts-ignore
Review Comment:
I believe `// @ts-expect-error` is the correct syntax for testing with incorrect types
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] zhaoyongjie commented on a diff in pull request #19587: chore: cleanup as unknown conversion
Posted by GitBox <gi...@apache.org>.
zhaoyongjie commented on code in PR #19587:
URL: https://github.com/apache/superset/pull/19587#discussion_r845760699
##########
superset-frontend/packages/superset-ui-core/src/color/utils.ts:
##########
@@ -75,7 +75,16 @@ export function getAnalogousColors(colors: string[], results: number) {
}
export function addAlpha(color: string, opacity: number): string {
- // coerce values so ti is between 0 and 1.
Review Comment:
bycatch: fix codes coverage.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] zhaoyongjie commented on a diff in pull request #19587: Cleanup asunknown
Posted by GitBox <gi...@apache.org>.
zhaoyongjie commented on code in PR #19587:
URL: https://github.com/apache/superset/pull/19587#discussion_r845080340
##########
superset-frontend/src/SqlLab/components/QuerySearch/index.tsx:
##########
@@ -247,7 +247,7 @@ function QuerySearch({ actions, displayLimit }: QuerySearchProps) {
value: s,
label: s,
}))}
- value={status as unknown as undefined}
+ value={{ value: status, label: status }}
Review Comment:
same before
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] zhaoyongjie merged pull request #19587: chore: cleanup as unknown conversion
Posted by GitBox <gi...@apache.org>.
zhaoyongjie merged PR #19587:
URL: https://github.com/apache/superset/pull/19587
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] zhaoyongjie commented on a diff in pull request #19587: Cleanup asunknown
Posted by GitBox <gi...@apache.org>.
zhaoyongjie commented on code in PR #19587:
URL: https://github.com/apache/superset/pull/19587#discussion_r845078325
##########
superset-frontend/packages/superset-ui-core/test/query/buildQueryObject.test.ts:
##########
@@ -285,7 +285,8 @@ describe('buildQueryObject', () => {
datasource: '5__table',
granularity_sqla: 'ds',
viz_type: 'table',
- url_params: null as unknown as undefined,
+ // @ts-ignore
Review Comment:
ignore is used for the test case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] zhaoyongjie commented on a diff in pull request #19587: Cleanup asunknown
Posted by GitBox <gi...@apache.org>.
zhaoyongjie commented on code in PR #19587:
URL: https://github.com/apache/superset/pull/19587#discussion_r845080028
##########
superset-frontend/src/SqlLab/components/QuerySearch/index.tsx:
##########
@@ -226,7 +226,7 @@ function QuerySearch({ actions, displayLimit }: QuerySearchProps) {
value: xt,
label: xt,
}))}
- value={from as unknown as undefined}
+ value={{ value: from, label: from }}
Review Comment:
bycatch: use **object** fill in Select value
##########
superset-frontend/src/SqlLab/components/QuerySearch/index.tsx:
##########
@@ -235,7 +235,7 @@ function QuerySearch({ actions, displayLimit }: QuerySearchProps) {
name="select-to"
placeholder={t('[To]-')}
options={TIME_OPTIONS.map(xt => ({ value: xt, label: xt }))}
- value={to as unknown as undefined}
+ value={{ value: to, label: to }}
Review Comment:
same before
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] zhaoyongjie commented on a diff in pull request #19587: Cleanup asunknown
Posted by GitBox <gi...@apache.org>.
zhaoyongjie commented on code in PR #19587:
URL: https://github.com/apache/superset/pull/19587#discussion_r845081855
##########
superset-frontend/src/views/CRUD/data/database/DatabaseModal/index.tsx:
##########
@@ -371,11 +371,11 @@ function dbReducer(
action.payload.configuration_method ===
CONFIGURATION_METHOD.DYNAMIC_FORM
) {
- const engineParamsCatalog = Object.keys(
+ const engineParamsCatalog = Object.entries(
extra_json?.engine_params?.catalog || {},
- ).map(e => ({
- name: e,
- value: extra_json?.engine_params?.catalog[e],
+ ).map(([key, value]) => ({
+ name: key,
+ value,
Review Comment:
same logical substitution
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] zhaoyongjie commented on a diff in pull request #19587: Cleanup asunknown
Posted by GitBox <gi...@apache.org>.
zhaoyongjie commented on code in PR #19587:
URL: https://github.com/apache/superset/pull/19587#discussion_r845080756
##########
superset-frontend/src/dashboard/util/getFormDataWithExtraFilters.test.ts:
##########
@@ -63,16 +59,8 @@ describe('getFormDataWithExtraFilters', () => {
},
sliceId: chartId,
nativeFilters: {
+ filters: {},
filterSets: {},
- filters: {
Review Comment:
useless fields
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] commented on pull request #19587: chore: cleanup as unknown conversion
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on PR #19587:
URL: https://github.com/apache/superset/pull/19587#issuecomment-1092434161
# [Codecov](https://codecov.io/gh/apache/superset/pull/19587?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#19587](https://codecov.io/gh/apache/superset/pull/19587?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (001b975) into [master](https://codecov.io/gh/apache/superset/commit/44e3103fc9029edd4c7fd1c8402607eecebeb1b3?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (44e3103) will **increase** coverage by `0.02%`.
> The diff coverage is `0.00%`.
```diff
@@ Coverage Diff @@
## master #19587 +/- ##
==========================================
+ Coverage 66.65% 66.68% +0.02%
==========================================
Files 1680 1681 +1
Lines 64292 64305 +13
Branches 6564 6565 +1
==========================================
+ Hits 42855 42880 +25
+ Misses 19735 19731 -4
+ Partials 1702 1694 -8
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `51.51% <0.00%> (+0.05%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/19587?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...lugin-chart-echarts/src/Timeseries/transformers.ts](https://codecov.io/gh/apache/superset/pull/19587/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9wbHVnaW4tY2hhcnQtZWNoYXJ0cy9zcmMvVGltZXNlcmllcy90cmFuc2Zvcm1lcnMudHM=) | `51.23% <ø> (ø)` | |
| [...ontend/src/SqlLab/components/QuerySearch/index.tsx](https://codecov.io/gh/apache/superset/pull/19587/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1F1ZXJ5U2VhcmNoL2luZGV4LnRzeA==) | `73.07% <ø> (ø)` | |
| [...set-frontend/src/dashboard/util/injectCustomCss.ts](https://codecov.io/gh/apache/superset/pull/19587/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2luamVjdEN1c3RvbUNzcy50cw==) | `69.23% <0.00%> (ø)` | |
| [...c/views/CRUD/data/database/DatabaseModal/index.tsx](https://codecov.io/gh/apache/superset/pull/19587/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9kYXRhYmFzZS9EYXRhYmFzZU1vZGFsL2luZGV4LnRzeA==) | `32.79% <0.00%> (ø)` | |
| [...ntend/packages/superset-ui-core/src/color/utils.ts](https://codecov.io/gh/apache/superset/pull/19587/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY29yZS9zcmMvY29sb3IvdXRpbHMudHM=) | `97.14% <0.00%> (-2.86%)` | :arrow_down: |
| [...frontend/src/views/CRUD/alert/AlertReportModal.tsx](https://codecov.io/gh/apache/superset/pull/19587/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvYWxlcnQvQWxlcnRSZXBvcnRNb2RhbC50c3g=) | `52.08% <0.00%> (-0.30%)` | :arrow_down: |
| [...ins/legacy-plugin-chart-partition/src/Partition.js](https://codecov.io/gh/apache/superset/pull/19587/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LXBhcnRpdGlvbi9zcmMvUGFydGl0aW9uLmpz) | `0.00% <0.00%> (ø)` | |
| [...ins/legacy-plugin-chart-sankey/src/ReactSankey.jsx](https://codecov.io/gh/apache/superset/pull/19587/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LXNhbmtleS9zcmMvUmVhY3RTYW5rZXkuanN4) | `0.00% <0.00%> (ø)` | |
| [...s/legacy-plugin-chart-horizon/src/HorizonChart.jsx](https://codecov.io/gh/apache/superset/pull/19587/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LWhvcml6b24vc3JjL0hvcml6b25DaGFydC5qc3g=) | `0.00% <0.00%> (ø)` | |
| [...acy-plugin-chart-paired-t-test/src/PairedTTest.jsx](https://codecov.io/gh/apache/superset/pull/19587/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LXBhaXJlZC10LXRlc3Qvc3JjL1BhaXJlZFRUZXN0LmpzeA==) | `0.00% <0.00%> (ø)` | |
| ... and [8 more](https://codecov.io/gh/apache/superset/pull/19587/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/19587?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/19587?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [44e3103...001b975](https://codecov.io/gh/apache/superset/pull/19587?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] zhaoyongjie commented on a diff in pull request #19587: Cleanup asunknown
Posted by GitBox <gi...@apache.org>.
zhaoyongjie commented on code in PR #19587:
URL: https://github.com/apache/superset/pull/19587#discussion_r845082492
##########
superset-frontend/src/views/CRUD/data/database/types.ts:
##########
@@ -79,7 +79,7 @@ export type DatabaseObject = {
// Extra
extra_json?: {
engine_params?: {
- catalog: Record<any, any> | string;
+ catalog?: Record<any, any> | string;
Review Comment:
`catalog` is a optional field.
##########
superset-frontend/src/views/CRUD/data/database/types.ts:
##########
@@ -79,7 +79,7 @@ export type DatabaseObject = {
// Extra
extra_json?: {
engine_params?: {
- catalog: Record<any, any> | string;
+ catalog?: Record<any, any> | string;
Review Comment:
`catalog` is an optional field.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] zhaoyongjie commented on a diff in pull request #19587: Cleanup asunknown
Posted by GitBox <gi...@apache.org>.
zhaoyongjie commented on code in PR #19587:
URL: https://github.com/apache/superset/pull/19587#discussion_r845082492
##########
superset-frontend/src/views/CRUD/data/database/types.ts:
##########
@@ -79,7 +79,7 @@ export type DatabaseObject = {
// Extra
extra_json?: {
engine_params?: {
- catalog: Record<any, any> | string;
+ catalog?: Record<any, any> | string;
Review Comment:
`catalog` is an optional field in engine params
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org