You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by "xiaoxiang781216 (via GitHub)" <gi...@apache.org> on 2023/03/06 08:49:52 UTC
[GitHub] [nuttx] xiaoxiang781216 opened a new pull request, #8735: net: Remove the dummy file_sendfile from sock_intf_s
xiaoxiang781216 opened a new pull request, #8735:
URL: https://github.com/apache/nuttx/pull/8735
## Summary
- net: Make si_bind callback optional
- net: Make si_getsockname callback optional
- net: Remove the empty si_getpeername implementation
- net: Make si_listen callback optional
- net: Make si_connect callback optional
- net: Make si_accept callback optional
- net: Make si_poll callback optional
## Impact
Code refactor only
## Testing
CI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] xiaoxiang781216 commented on a diff in pull request #8735: net: Remove the dummy implementation from sock_intf_s
Posted by "xiaoxiang781216 (via GitHub)" <gi...@apache.org>.
xiaoxiang781216 commented on code in PR #8735:
URL: https://github.com/apache/nuttx/pull/8735#discussion_r1126730432
##########
net/socket/listen.c:
##########
@@ -82,7 +82,12 @@ int psock_listen(FAR struct socket *psock, int backlog)
/* Let the address family's listen() method handle the operation */
- DEBUGASSERT(psock->s_sockif != NULL && psock->s_sockif->si_listen != NULL);
+ DEBUGASSERT(psock->s_sockif != NULL)
Review Comment:
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] pkarashchenko merged pull request #8735: net: Remove the dummy implementation from sock_intf_s
Posted by "pkarashchenko (via GitHub)" <gi...@apache.org>.
pkarashchenko merged PR #8735:
URL: https://github.com/apache/nuttx/pull/8735
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] xiaoxiang781216 commented on pull request #8735: net: Remove the dummy implementation from sock_intf_s
Posted by "xiaoxiang781216 (via GitHub)" <gi...@apache.org>.
xiaoxiang781216 commented on PR #8735:
URL: https://github.com/apache/nuttx/pull/8735#issuecomment-1455793860
> Please remove extra whitespace on blank lines
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] pkarashchenko commented on a diff in pull request #8735: net: Remove the dummy implementation from sock_intf_s
Posted by "pkarashchenko (via GitHub)" <gi...@apache.org>.
pkarashchenko commented on code in PR #8735:
URL: https://github.com/apache/nuttx/pull/8735#discussion_r1126267607
##########
net/socket/listen.c:
##########
@@ -82,7 +82,12 @@ int psock_listen(FAR struct socket *psock, int backlog)
/* Let the address family's listen() method handle the operation */
- DEBUGASSERT(psock->s_sockif != NULL && psock->s_sockif->si_listen != NULL);
+ DEBUGASSERT(psock->s_sockif != NULL)
Review Comment:
```suggestion
DEBUGASSERT(psock->s_sockif != NULL);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org