You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "srielau (via GitHub)" <gi...@apache.org> on 2023/05/15 21:25:45 UTC

[GitHub] [spark] srielau commented on a diff in pull request #41007: [WIP][SPARK-43205] IDENTIFIER clause

srielau commented on code in PR #41007:
URL: https://github.com/apache/spark/pull/41007#discussion_r1194378050


##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala:
##########
@@ -2108,6 +2123,18 @@ class Analyzer(override val catalogManager: CatalogManager) extends RuleExecutor
           }
         }
 
+      // Resolve IDENTIFIER clause.
+      case u@UnresolvedRelationIdentifierClause(expr) if expr.resolved =>
+        UnresolvedRelation(IdentifierClauseUtil.evalIdentifierClause(expr))
+
+      // Resolve IDENTIFIER clause and reduce to a regular unresolved table function
+      case u@UnresolvedTableValuedFunctionIdentifierClause(expr, args) if expr.resolved =>
+        UnresolvedTableValuedFunction(IdentifierClauseUtil.evalIdentifierClause(expr), args)
+
+      // Resolve IDENTIFIER clause and reduce to a regular unresolved TVF aliases

Review Comment:
   Addressed



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org