You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@calcite.apache.org by Julian Hyde <jh...@apache.org> on 2023/06/07 21:34:44 UTC
PR 3250 (PairList, LintTest, Puffin, TestUnsafe)
Can I please get a review for PR 3250? It has several commits that are
loosely connected.
CALCITE-5762 should be reviewed from a security perspective (because
it deals with unsafe methods such as ProcessBuilder).
CALCITE-5764 adds a fun class called Puffin that brings the scripting
capabilities of 'awk' into Java.
https://github.com/apache/calcite/pull/3250
Julian
Re: PR 3250 (PairList, LintTest, Puffin, TestUnsafe)
Posted by Benchao Li <li...@apache.org>.
> This may cause existing open PRs to give errors. Sorry about
that, but it should help us all write better commit messages. (And
reduce nagging from reviewers like me.)
Thanks Julian for adding this checking. Recently I was also thinking about
introducing some documents about how to write a good commit message and
Jira summary, by summarizing the Jira and PR comments, mostly from you.
Adding lint checks is much better than documentation.
Julian Hyde <jh...@apache.org> 于2023年6月9日周五 08:09写道：
> I've merged this to main. (Thanks for the review, Zhe Hu!)
>
> There are new lint checks on code (especially javadoc) and commit
> messages. This may cause existing open PRs to give errors. Sorry about
> that, but it should help us all write better commit messages. (And
> reduce nagging from reviewers like me.)
>
> Julian
>
> On Wed, Jun 7, 2023 at 2:34 PM Julian Hyde <jh...@apache.org> wrote:
> >
> > Can I please get a review for PR 3250? It has several commits that are
> > loosely connected.
> >
> > CALCITE-5762 should be reviewed from a security perspective (because
> > it deals with unsafe methods such as ProcessBuilder).
> >
> > CALCITE-5764 adds a fun class called Puffin that brings the scripting
> > capabilities of 'awk' into Java.
> >
> > https://github.com/apache/calcite/pull/3250
> >
> > Julian
>
--
Best,
Benchao Li
Re: PR 3250 (PairList, LintTest, Puffin, TestUnsafe)
Posted by Julian Hyde <jh...@apache.org>.
I've merged this to main. (Thanks for the review, Zhe Hu!)
There are new lint checks on code (especially javadoc) and commit
messages. This may cause existing open PRs to give errors. Sorry about
that, but it should help us all write better commit messages. (And
reduce nagging from reviewers like me.)
Julian
On Wed, Jun 7, 2023 at 2:34 PM Julian Hyde <jh...@apache.org> wrote:
>
> Can I please get a review for PR 3250? It has several commits that are
> loosely connected.
>
> CALCITE-5762 should be reviewed from a security perspective (because
> it deals with unsafe methods such as ProcessBuilder).
>
> CALCITE-5764 adds a fun class called Puffin that brings the scripting
> capabilities of 'awk' into Java.
>
> https://github.com/apache/calcite/pull/3250
>
> Julian