You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Andrzej Bialecki (JIRA)" <ji...@apache.org> on 2011/02/18 19:57:38 UTC

[jira] Created: (SOLR-2375) Store & Load functionality for Suggester Lookup implementations

Store & Load functionality for Suggester Lookup implementations
---------------------------------------------------------------

                 Key: SOLR-2375
                 URL: https://issues.apache.org/jira/browse/SOLR-2375
             Project: Solr
          Issue Type: Improvement
          Components: SearchComponents - other
    Affects Versions: 3.2, 4.0
            Reporter: Andrzej Bialecki 
            Assignee: Andrzej Bialecki 


Trie-based autocomplete API has two methods, store(File) and load(File) to persist the trie representation on disk, but in the committed code (SOLR-1316) these methods were not implemented. This issue adds an implementation for both TSTLookup and JaspellLookup.

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


[jira] Commented: (SOLR-2375) Store & Load functionality for Suggester Lookup implementations

Posted by "Mark Miller (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/SOLR-2375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13000863#comment-13000863 ] 

Mark Miller commented on SOLR-2375:
-----------------------------------

bq. If there are no objections I'd like to commit this shortly.

+1 - looks good!

> Store & Load functionality for Suggester Lookup implementations
> ---------------------------------------------------------------
>
>                 Key: SOLR-2375
>                 URL: https://issues.apache.org/jira/browse/SOLR-2375
>             Project: Solr
>          Issue Type: Improvement
>          Components: SearchComponents - other
>            Reporter: Andrzej Bialecki 
>            Assignee: Andrzej Bialecki 
>             Fix For: 3.2, 4.0
>
>         Attachments: SOLR-2375-2.patch, SOLR-2375-3.patch, SOLR-2375.patch, SOLR-2375.patch
>
>
> Trie-based autocomplete API has two methods, store(File) and load(File) to persist the trie representation on disk, but in the committed code (SOLR-1316) these methods were not implemented. This issue adds an implementation for both TSTLookup and JaspellLookup.

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


[jira] Updated: (SOLR-2375) Store & Load functionality for Suggester Lookup implementations

Posted by "Mark Miller (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SOLR-2375?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Mark Miller updated SOLR-2375:
------------------------------

    Attachment: SOLR-2375.patch

Couple small changes:

close DataOutputStream and DataInputStream in JaspellLookup

replace e.printStackTraces

> Store & Load functionality for Suggester Lookup implementations
> ---------------------------------------------------------------
>
>                 Key: SOLR-2375
>                 URL: https://issues.apache.org/jira/browse/SOLR-2375
>             Project: Solr
>          Issue Type: Improvement
>          Components: SearchComponents - other
>            Reporter: Andrzej Bialecki 
>            Assignee: Andrzej Bialecki 
>             Fix For: 3.2, 4.0
>
>         Attachments: SOLR-2375-2.patch, SOLR-2375.patch, SOLR-2375.patch
>
>
> Trie-based autocomplete API has two methods, store(File) and load(File) to persist the trie representation on disk, but in the committed code (SOLR-1316) these methods were not implemented. This issue adds an implementation for both TSTLookup and JaspellLookup.

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


[jira] Updated: (SOLR-2375) Store & Load functionality for Suggester Lookup implementations

Posted by "Andrzej Bialecki (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SOLR-2375?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Andrzej Bialecki  updated SOLR-2375:
------------------------------------

    Attachment: SOLR-2375-2.patch

Improved patch & unit test. This now actually loads the lookup data if present and if storeDir is defined.

> Store & Load functionality for Suggester Lookup implementations
> ---------------------------------------------------------------
>
>                 Key: SOLR-2375
>                 URL: https://issues.apache.org/jira/browse/SOLR-2375
>             Project: Solr
>          Issue Type: Improvement
>          Components: SearchComponents - other
>    Affects Versions: 3.2, 4.0
>            Reporter: Andrzej Bialecki 
>            Assignee: Andrzej Bialecki 
>         Attachments: SOLR-2375-2.patch, SOLR-2375.patch
>
>
> Trie-based autocomplete API has two methods, store(File) and load(File) to persist the trie representation on disk, but in the committed code (SOLR-1316) these methods were not implemented. This issue adds an implementation for both TSTLookup and JaspellLookup.

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


[jira] Updated: (SOLR-2375) Store & Load functionality for Suggester Lookup implementations

Posted by "Andrzej Bialecki (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SOLR-2375?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Andrzej Bialecki  updated SOLR-2375:
------------------------------------

    Attachment: SOLR-2375.patch

Patch that implements store/load.

> Store & Load functionality for Suggester Lookup implementations
> ---------------------------------------------------------------
>
>                 Key: SOLR-2375
>                 URL: https://issues.apache.org/jira/browse/SOLR-2375
>             Project: Solr
>          Issue Type: Improvement
>          Components: SearchComponents - other
>    Affects Versions: 3.2, 4.0
>            Reporter: Andrzej Bialecki 
>            Assignee: Andrzej Bialecki 
>         Attachments: SOLR-2375.patch
>
>
> Trie-based autocomplete API has two methods, store(File) and load(File) to persist the trie representation on disk, but in the committed code (SOLR-1316) these methods were not implemented. This issue adds an implementation for both TSTLookup and JaspellLookup.

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


[jira] Resolved: (SOLR-2375) Store & Load functionality for Suggester Lookup implementations

Posted by "Andrzej Bialecki (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SOLR-2375?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Andrzej Bialecki  resolved SOLR-2375.
-------------------------------------

    Resolution: Fixed

Committed to trunk rev. 1075804 and to branch_3x rev. 1075841.

> Store & Load functionality for Suggester Lookup implementations
> ---------------------------------------------------------------
>
>                 Key: SOLR-2375
>                 URL: https://issues.apache.org/jira/browse/SOLR-2375
>             Project: Solr
>          Issue Type: Improvement
>          Components: SearchComponents - other
>            Reporter: Andrzej Bialecki 
>            Assignee: Andrzej Bialecki 
>             Fix For: 3.2, 4.0
>
>         Attachments: SOLR-2375-2.patch, SOLR-2375-3.patch, SOLR-2375.patch, SOLR-2375.patch
>
>
> Trie-based autocomplete API has two methods, store(File) and load(File) to persist the trie representation on disk, but in the committed code (SOLR-1316) these methods were not implemented. This issue adds an implementation for both TSTLookup and JaspellLookup.

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


[jira] Updated: (SOLR-2375) Store & Load functionality for Suggester Lookup implementations

Posted by "Andrzej Bialecki (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SOLR-2375?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Andrzej Bialecki  updated SOLR-2375:
------------------------------------

    Attachment: SOLR-2375-3.patch

Fix a bug where Integer-s where stored in a tree instead of Float-s.

If there are no objections I'd like to commit this shortly.

> Store & Load functionality for Suggester Lookup implementations
> ---------------------------------------------------------------
>
>                 Key: SOLR-2375
>                 URL: https://issues.apache.org/jira/browse/SOLR-2375
>             Project: Solr
>          Issue Type: Improvement
>          Components: SearchComponents - other
>            Reporter: Andrzej Bialecki 
>            Assignee: Andrzej Bialecki 
>             Fix For: 3.2, 4.0
>
>         Attachments: SOLR-2375-2.patch, SOLR-2375-3.patch, SOLR-2375.patch, SOLR-2375.patch
>
>
> Trie-based autocomplete API has two methods, store(File) and load(File) to persist the trie representation on disk, but in the committed code (SOLR-1316) these methods were not implemented. This issue adds an implementation for both TSTLookup and JaspellLookup.

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


[jira] Updated: (SOLR-2375) Store & Load functionality for Suggester Lookup implementations

Posted by "Mark Miller (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SOLR-2375?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Mark Miller updated SOLR-2375:
------------------------------

    Affects Version/s:     (was: 3.2)
                           (was: 4.0)
        Fix Version/s: 4.0
                       3.2

> Store & Load functionality for Suggester Lookup implementations
> ---------------------------------------------------------------
>
>                 Key: SOLR-2375
>                 URL: https://issues.apache.org/jira/browse/SOLR-2375
>             Project: Solr
>          Issue Type: Improvement
>          Components: SearchComponents - other
>            Reporter: Andrzej Bialecki 
>            Assignee: Andrzej Bialecki 
>             Fix For: 3.2, 4.0
>
>         Attachments: SOLR-2375-2.patch, SOLR-2375.patch
>
>
> Trie-based autocomplete API has two methods, store(File) and load(File) to persist the trie representation on disk, but in the committed code (SOLR-1316) these methods were not implemented. This issue adds an implementation for both TSTLookup and JaspellLookup.

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org