You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@yunikorn.apache.org by GitBox <gi...@apache.org> on 2021/01/08 07:49:52 UTC

[GitHub] [incubator-yunikorn-core] yangwwei commented on pull request #236: [YUNIKORN-476] placeholder allocation and swap

yangwwei commented on pull request #236:
URL: https://github.com/apache/incubator-yunikorn-core/pull/236#issuecomment-756606256


   hi @TaoYang526  thanks for the draft PR. At the first glance, I wasn't able to fully understand some of the places. After reading more info from the previous design doc in https://issues.apache.org/jira/browse/YUNIKORN-1. They start to make sense. I pretty like interfaces defined in this PR, the confusion part is `queue_request_manager_plugin.go`.  I feel we can somehow optimize this to make it simpler. I will look into more details and get back to you. Thanks.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org