You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mynewt.apache.org by GitBox <gi...@apache.org> on 2020/10/27 15:53:55 UTC
[GitHub] [mynewt-newtmgr] nkaje opened a new pull request #177: bll_sesn_cfg_windows: Fix build error for windows
nkaje opened a new pull request #177:
URL: https://github.com/apache/mynewt-newtmgr/pull/177
Fix the following build error in windows.
C:\Users\ryan.erickson>go get github.com/apache/mynewt-mcumgr-cli/mcumgr
go\src\mynewt.apache.org\newtmgr\newtmgr\bll\bll_sesn_cfg_windows.go:35:15:
undefined: nmcoap.MsgFilter
go\src\mynewt.apache.org\newtmgr\newtmgr\bll\bll_sesn_cfg_windows.go:36:15:
undefined: nmcoap.MsgFilter
Building tested with:
`$GOOS=windows go build`
Signed-off-by: Naveen Kaje <na...@juul.com>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-newtmgr] nkaje commented on pull request #177: bll_sesn_cfg_windows: Fix build error for windows
Posted by GitBox <gi...@apache.org>.
nkaje commented on pull request #177:
URL: https://github.com/apache/mynewt-newtmgr/pull/177#issuecomment-717342857
Addressing https://github.com/apache/mynewt-mcumgr-cli/issues/19
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-newtmgr] nkaje commented on a change in pull request #177: bll_sesn_cfg_windows: Fix build error for windows
Posted by GitBox <gi...@apache.org>.
nkaje commented on a change in pull request #177:
URL: https://github.com/apache/mynewt-newtmgr/pull/177#discussion_r513520640
##########
File path: newtmgr/bll/bll_sesn_cfg_windows.go
##########
@@ -32,8 +32,8 @@ type BllSesnCfg struct {
MgmtProto sesn.MgmtProto
PreferredMtu int
ConnTimeout time.Duration
- TxFilterCb nmcoap.MsgFilter
- RxFilterCb nmcoap.MsgFilter
+ TxFilter nmcoap.TxMsgFilter
+ RxFilter nmcoap.RxMsgFilter
Review comment:
Updated commit message.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-newtmgr] utzig commented on a change in pull request #177: bll_sesn_cfg_windows: Fix build error for windows
Posted by GitBox <gi...@apache.org>.
utzig commented on a change in pull request #177:
URL: https://github.com/apache/mynewt-newtmgr/pull/177#discussion_r513481484
##########
File path: newtmgr/bll/bll_sesn_cfg_windows.go
##########
@@ -32,8 +32,8 @@ type BllSesnCfg struct {
MgmtProto sesn.MgmtProto
PreferredMtu int
ConnTimeout time.Duration
- TxFilterCb nmcoap.MsgFilter
- RxFilterCb nmcoap.MsgFilter
+ TxFilter nmcoap.TxMsgFilter
+ RxFilter nmcoap.RxMsgFilter
Review comment:
Does changing the variable names have no effect on the code using them?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-newtmgr] nkaje merged pull request #177: bll_sesn_cfg_windows: Fix build error for windows
Posted by GitBox <gi...@apache.org>.
nkaje merged pull request #177:
URL: https://github.com/apache/mynewt-newtmgr/pull/177
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-newtmgr] utzig commented on a change in pull request #177: bll_sesn_cfg_windows: Fix build error for windows
Posted by GitBox <gi...@apache.org>.
utzig commented on a change in pull request #177:
URL: https://github.com/apache/mynewt-newtmgr/pull/177#discussion_r513521902
##########
File path: newtmgr/bll/bll_sesn_cfg_windows.go
##########
@@ -32,8 +32,8 @@ type BllSesnCfg struct {
MgmtProto sesn.MgmtProto
PreferredMtu int
ConnTimeout time.Duration
- TxFilterCb nmcoap.MsgFilter
- RxFilterCb nmcoap.MsgFilter
+ TxFilter nmcoap.TxMsgFilter
+ RxFilter nmcoap.RxMsgFilter
Review comment:
Thanks, I should have suspected the reason! :-)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-newtmgr] utzig commented on a change in pull request #177: bll_sesn_cfg_windows: Fix build error for windows
Posted by GitBox <gi...@apache.org>.
utzig commented on a change in pull request #177:
URL: https://github.com/apache/mynewt-newtmgr/pull/177#discussion_r513482415
##########
File path: newtmgr/bll/bll_sesn_cfg_windows.go
##########
@@ -32,8 +32,8 @@ type BllSesnCfg struct {
MgmtProto sesn.MgmtProto
PreferredMtu int
ConnTimeout time.Duration
- TxFilterCb nmcoap.MsgFilter
- RxFilterCb nmcoap.MsgFilter
+ TxFilter nmcoap.TxMsgFilter
+ RxFilter nmcoap.RxMsgFilter
Review comment:
Maybe the commit message should explain why `MsgFilter` is not available on Windows?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org