You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@pekko.apache.org by "pjfanning (via GitHub)" <gi...@apache.org> on 2023/08/29 14:13:16 UTC

[GitHub] [incubator-pekko-persistence-jdbc] pjfanning opened a new pull request, #84: publish 1.0 docs

pjfanning opened a new pull request, #84:
URL: https://github.com/apache/incubator-pekko-persistence-jdbc/pull/84

   equivalent of what we have in other repos


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org


[GitHub] [incubator-pekko-persistence-jdbc] pjfanning merged pull request #84: publish 1.0 docs

Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning merged PR #84:
URL: https://github.com/apache/incubator-pekko-persistence-jdbc/pull/84


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org


[GitHub] [incubator-pekko-persistence-jdbc] mdedetrich commented on a diff in pull request #84: publish 1.0 docs

Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on code in PR #84:
URL: https://github.com/apache/incubator-pekko-persistence-jdbc/pull/84#discussion_r1308995153


##########
.github/workflows/publish-1.0-docs.yml:
##########
@@ -0,0 +1,68 @@
+name: Publish 1.0 docs
+
+permissions:
+  contents: read
+
+on:
+  workflow_dispatch:
+
+jobs:
+  publish-docs:
+    # runs on main repo only
+    if: github.repository == 'apache/incubator-pekko-persistence-jdbc'
+    name: Publish
+    runs-on: ubuntu-20.04
+    env:
+      JAVA_OPTS: -Xms2G -Xmx2G -Xss2M -XX:ReservedCodeCacheSize=256M -Dfile.encoding=UTF-8
+    steps:
+      - name: Checkout
+        uses: actions/checkout@v3
+        with:
+          # we don't know what commit the last tag was it's safer to get entire repo so previousStableVersion resolves
+          fetch-depth: 0
+
+      - name: Setup Java 8
+        uses: actions/setup-java@v3
+        with:
+          distribution: temurin
+          java-version: 8

Review Comment:
   iirc all of our projects aside from pekko core (due to technical reasons) are built with JDK 8



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org


[GitHub] [incubator-pekko-persistence-jdbc] pjfanning commented on a diff in pull request #84: publish 1.0 docs

Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on code in PR #84:
URL: https://github.com/apache/incubator-pekko-persistence-jdbc/pull/84#discussion_r1308993686


##########
.github/workflows/publish-1.0-docs.yml:
##########
@@ -0,0 +1,68 @@
+name: Publish 1.0 docs
+
+permissions:
+  contents: read
+
+on:
+  workflow_dispatch:
+
+jobs:
+  publish-docs:
+    # runs on main repo only
+    if: github.repository == 'apache/incubator-pekko-persistence-jdbc'
+    name: Publish
+    runs-on: ubuntu-20.04
+    env:
+      JAVA_OPTS: -Xms2G -Xmx2G -Xss2M -XX:ReservedCodeCacheSize=256M -Dfile.encoding=UTF-8
+    steps:
+      - name: Checkout
+        uses: actions/checkout@v3
+        with:
+          # we don't know what commit the last tag was it's safer to get entire repo so previousStableVersion resolves
+          fetch-depth: 0
+
+      - name: Setup Java 8
+        uses: actions/setup-java@v3
+        with:
+          distribution: temurin
+          java-version: 8

Review Comment:
   this is what we use in the nightly build - I don't want to use a different java version in this build



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org


[GitHub] [incubator-pekko-persistence-jdbc] He-Pin commented on a diff in pull request #84: publish 1.0 docs

Posted by "He-Pin (via GitHub)" <gi...@apache.org>.
He-Pin commented on code in PR #84:
URL: https://github.com/apache/incubator-pekko-persistence-jdbc/pull/84#discussion_r1308932954


##########
.github/workflows/publish-1.0-docs.yml:
##########
@@ -0,0 +1,68 @@
+name: Publish 1.0 docs
+
+permissions:
+  contents: read
+
+on:
+  workflow_dispatch:
+
+jobs:
+  publish-docs:
+    # runs on main repo only
+    if: github.repository == 'apache/incubator-pekko-persistence-jdbc'
+    name: Publish
+    runs-on: ubuntu-20.04
+    env:
+      JAVA_OPTS: -Xms2G -Xmx2G -Xss2M -XX:ReservedCodeCacheSize=256M -Dfile.encoding=UTF-8
+    steps:
+      - name: Checkout
+        uses: actions/checkout@v3
+        with:
+          # we don't know what commit the last tag was it's safer to get entire repo so previousStableVersion resolves
+          fetch-depth: 0
+
+      - name: Setup Java 8
+        uses: actions/setup-java@v3
+        with:
+          distribution: temurin
+          java-version: 8

Review Comment:
   Not 11?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org