[GitHub] moltzaum opened a new pull request #3319: Revert "Use JSONIntStr for user endpoint"

[GitBox <gi...@apache.org>]

moltzaum opened a new pull request #3319: Revert "Use JSONIntStr for user endpoint"
URL: https://github.com/apache/trafficcontrol/pull/3319
 
 
   This reverts commit ccec233e2c7951e28b42bf370e5fc6b5c498df95.
   
   In the conversion from perl to go, perl will accept strings or ints as
   integers because it is a weakly typed language. The use of JSONIntStr
   allowed the same to happen in golang (in this case for a single
   endpoint).
   
   The use of JSONIntStr would keep the functionaility from perl, however I
   am reverting the change because keeping this behavior implies that we
   want to maintain it in the future for all other endpoints.
   
   When the original commit was made, there was not yet a consensus to keep the bug as is.
   Here is a part of the discussion (the rest was in slack):
   https://lists.apache.org/thread.html/f0624d4386f1de1f18b322436df6fa0402bf34314abd4b108edc5fde@%3Cdev.trafficcontrol.apache.org%3E
   
   #### What does this PR do?
   
   Fixes #(issue_number)
   
   #### Which TC components are affected by this PR?
   
   - [ ] Documentation
   - [ ] Grove
   - [ ] Traffic Analytics
   - [ ] Traffic Monitor
   - [ ] Traffic Ops
   - [ ] Traffic Ops ORT
   - [ ] Traffic Portal
   - [ ] Traffic Router
   - [ ] Traffic Stats
   - [ ] Traffic Vault
   - [ ] Other _________
   
   #### What is the best way to verify this PR?
   
   
   #### Check all that apply
   
   - [ ] This PR includes tests
   - [ ] This PR includes documentation updates
   - [ ] This PR includes an update to CHANGELOG.md
   - [ ] This PR includes all required license headers
   - [ ] This PR includes a database migration (ensure that migration sequence is correct)
   - [ ] This PR fixes a serious security flaw. Read more: [www.apache.org/security](http://www.apache.org/security/)
   
   <!--
       Licensed to the Apache Software Foundation (ASF) under one
       or more contributor license agreements.  See the NOTICE file
       distributed with this work for additional information
       regarding copyright ownership.  The ASF licenses this file
       to you under the Apache License, Version 2.0 (the
       "License"); you may not use this file except in compliance
       with the License.  You may obtain a copy of the License at
   
         http://www.apache.org/licenses/LICENSE-2.0
   
       Unless required by applicable law or agreed to in writing,
       software distributed under the License is distributed on an
       "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
       KIND, either express or implied.  See the License for the
       specific language governing permissions and limitations
       under the License.
   -->
   
   
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services