You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/08/09 08:41:52 UTC

[GitHub] [airflow] malthe opened a new issue #17498: Connection health check

malthe opened a new issue #17498:
URL: https://github.com/apache/airflow/issues/17498


   **Description**
   
   Add an option to enable a "Connection health check" on a connection.
   
   This would have the effect that a background connection test would be scheduled to run with a configurable interval (globally configured). The test would be executed by a worker.
   
   If one or more connection health checks currently fail, a message on the main page will be shown. In addition, the connection list will show a health status for each entry.
   
   **Use case / motivation**
   
   It's previously been proposed to run a connection check as part of saving a new connection through the Airflow UI (see related issues below).
   
   But such a health check is really an on-going concern – similar to how DAG input files are scanned for syntax errors and reported on the main page.
   
   **Are you willing to submit a PR?**
   
   Yes
   
   **Related Issues**
   
   - https://issues.apache.org/jira/browse/AIRFLOW-2998
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] uranusjr commented on issue #17498: Connection health check

Posted by GitBox <gi...@apache.org>.
uranusjr commented on issue #17498:
URL: https://github.com/apache/airflow/issues/17498#issuecomment-952506925


   How should we proceed now 2.2 is released?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] potiuk edited a comment on issue #17498: Connection health check

Posted by GitBox <gi...@apache.org>.
potiuk edited a comment on issue #17498:
URL: https://github.com/apache/airflow/issues/17498#issuecomment-953029438


   @uranusjr: We mark it for milestone 2.2.0, we link the issue manualy (sometimes linking PR from issue does not work but usually it work the other way -- you can go to PR and link the issue to the PR 🤷 .
   
   Then we close the issue.
   
   This is the GREAT by-product of making PR#s as our "changelog entries". We do not have to modify the changelog because the PR that fixed it has been (had to be) correctly mentioned in the changelog. Linking the issue to such closed PR just "refines" the state of the issue and makes it synced with the PR which is already in the changelog. 
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] potiuk edited a comment on issue #17498: Connection health check

Posted by GitBox <gi...@apache.org>.
potiuk edited a comment on issue #17498:
URL: https://github.com/apache/airflow/issues/17498#issuecomment-953029438


   @uranusjr: We mark it for milestone 2.2.0, we link the issue manualy (sometimes linking PR from issue does not work but usually it works the other way -- you can go to PR and link the issue to the PR 🤷 .
   
   Then we close the issue.
   
   This is the GREAT by-product of making PR#s as our "changelog entries". After such update - we do not have to modify the changelog because the PR that fixed it has been (had to be) correctly mentioned in the changelog. Linking the issue to such closed PR just "refines" the state of the issue and makes it synced with the PR which is already in the changelog. 
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] malthe commented on issue #17498: Connection health check

Posted by GitBox <gi...@apache.org>.
malthe commented on issue #17498:
URL: https://github.com/apache/airflow/issues/17498#issuecomment-895166621


   @BasPH oh awesome – when is this coming to an Airflow release? I don't see it in the latest 2.1.2 release.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] BasPH commented on issue #17498: Connection health check

Posted by GitBox <gi...@apache.org>.
BasPH commented on issue #17498:
URL: https://github.com/apache/airflow/issues/17498#issuecomment-895160429


   I realize your issue suggests different behaviour, but linking this here for reference https://github.com/apache/airflow/pull/15795


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] potiuk commented on issue #17498: Connection health check

Posted by GitBox <gi...@apache.org>.
potiuk commented on issue #17498:
URL: https://github.com/apache/airflow/issues/17498#issuecomment-953029438


   @uranusjr: We mark it for milestone 2.2.0, we link the issue manua (sometimes linking PR from issue does not work but usually it work the other way -- you can go to PR and link the issue to the PR 🤷 .
   
   Then we close the issue.
   
   This is the GREAT by-product of making PR#s as our "changelog entries". We do not have to modify the changelog because the PR that fixed it has been (had to be) correctly mentioned in the changelog. Linking the issue to such closed PR just "refines" the state of the issue and makes it synced with the PR which is already in the changelog. 
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] potiuk closed issue #17498: Connection health check

Posted by GitBox <gi...@apache.org>.
potiuk closed issue #17498:
URL: https://github.com/apache/airflow/issues/17498


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] BasPH commented on issue #17498: Connection health check

Posted by GitBox <gi...@apache.org>.
BasPH commented on issue #17498:
URL: https://github.com/apache/airflow/issues/17498#issuecomment-895167741


   It's currently set for Airflow 2.2 (you can see a "Milestone" section in the PR).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] potiuk edited a comment on issue #17498: Connection health check

Posted by GitBox <gi...@apache.org>.
potiuk edited a comment on issue #17498:
URL: https://github.com/apache/airflow/issues/17498#issuecomment-953029438


   @uranusjr: We mark it for milestone 2.2.0, we link the issue manualy (sometimes linking PR from issue does not work but usually it works the other way -- you can go to PR and link the issue to the PR 🤷 .
   
   Then we close the issue.
   
   This is the GREAT by-product of making PR#s as our "changelog entries". We do not have to modify the changelog because the PR that fixed it has been (had to be) correctly mentioned in the changelog. Linking the issue to such closed PR just "refines" the state of the issue and makes it synced with the PR which is already in the changelog. 
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org