You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@pekko.apache.org by "Philippus (via GitHub)" <gi...@apache.org> on 2026/08/08 20:11:45 UTC
[PR] Clean up k8s lease-related test files [pekko-management]
Philippus opened a new pull request, #928:
URL: https://github.com/apache/pekko-management/pull/928
Some files were in the wrong directory/package, also fixed some mistakes in the test descriptions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] Clean up k8s lease-related test files [pekko-management]
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on code in PR #928:
URL: https://github.com/apache/pekko-management/pull/928#discussion_r3741561858
##########
lease-kubernetes/src/test/scala/org/apache/pekko/coordination/lease/kubernetes/NativeKubernetesApiSpec.scala:
##########
@@ -199,7 +199,7 @@ class NativeKubernetesApiSpec
response shouldEqual Done
}
- "timeout on readLease" in {
+ "timeout on read lease" in {
Review Comment:
```suggestion
"timeout on readOrCreateLeaseResource" in {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] Clean up k8s lease-related test files [pekko-management]
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on code in PR #928:
URL: https://github.com/apache/pekko-management/pull/928#discussion_r3741557768
##########
lease-kubernetes/src/test/scala/org/apache/pekko/coordination/lease/kubernetes/KubernetesApiSpec.scala:
##########
@@ -218,7 +218,7 @@ class KubernetesApiSpec
response shouldEqual Done
}
- "timeout on readLease" in {
+ "timeout on read lease" in {
Review Comment:
```suggestion
"timeout on readOrCreateLeaseResource" in {
```
##########
lease-kubernetes/src/test/scala/org/apache/pekko/coordination/lease/kubernetes/KubernetesApiSpec.scala:
##########
@@ -218,7 +218,7 @@ class KubernetesApiSpec
response shouldEqual Done
}
- "timeout on readLease" in {
+ "timeout on read lease" in {
Review Comment:
the new test name doesn't seem quite right either - the function being tested is readOrCreateLeaseResource - maybe we could use that in the test name
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] Clean up k8s lease-related test files [pekko-management]
Posted by "Philippus (via GitHub)" <gi...@apache.org>.
Philippus merged PR #928:
URL: https://github.com/apache/pekko-management/pull/928
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org