You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@thrift.apache.org by cherrot <gi...@git.apache.org> on 2016/04/03 14:01:00 UTC

[GitHub] thrift pull request: THRIFT-3737 Improve isOpen() to give accurate...

Github user cherrot commented on the pull request:

    https://github.com/apache/thrift/pull/945#issuecomment-204951251
  
    Yes you are right, using `isActive` would invoke `select/poll` and `recv` system calls than a straight forward `send`. 
    
    As a lower layer library, I think it would be nice to provide a convenient API telling the underlying state. Users could decide whether to use this or not.
    
    And what is the [`peek` method in C++ lib](https://github.com/apache/thrift/blob/cdc83335d60756c4bfb0d2c8af7933500c9e3c06/lib/cpp/src/thrift/transport/TSocket.cpp#L181-L235) for? Is there anything wrong with it?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---