You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by phaitour <gi...@git.apache.org> on 2014/04/11 02:26:05 UTC
[GitHub] cordova-plugin-statusbar pull request: Added javascript event on s...
GitHub user phaitour opened a pull request:
https://github.com/apache/cordova-plugin-statusbar/pull/4
Added javascript event on status bar tap
A fake scrollview is added to the CDVViewController's view (but it's in the background). When the status bar is tapped, the scrollview will naturally be notified to scroll to the top and a new javascript event is fired.
This also has a fix for the webview frame calculations in the function hide. The calculation is ignored when the status bar is overlaid on top of the webview.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/sodacan/cordova-plugin-statusbar master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-plugin-statusbar/pull/4.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #4
----
commit b6e79629a4a1dffa26a7fdf983440afc9a43ccd1
Author: Tiancheng Zhu <ph...@gmail.com>
Date: 2014-04-10T23:25:47Z
fixing hide to adjust webview's frame only when status bar is not overlaying webview
commit 0c5c2c35bbdd4e9e191836bc50afd01c98a03807
Author: Tiancheng Zhu <ph...@gmail.com>
Date: 2014-04-10T23:56:24Z
adding fake scrollview to detect statusbar taps
commit d4c8f0bd5bb4ee83692032e048eb305e5ca83810
Author: Tiancheng Zhu <ph...@gmail.com>
Date: 2014-04-10T23:59:54Z
debugging
commit 76748897f7f6a4689f777bed58062f96b503a07a
Author: Tiancheng Zhu <ph...@gmail.com>
Date: 2014-04-11T00:13:58Z
disabling webview's detection of status bar tap
commit 2909b2492ae1eb6204c82a2b8ce16faa74c3443e
Author: Tiancheng Zhu <ph...@gmail.com>
Date: 2014-04-11T00:18:28Z
giving a size to the fake scrollview
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cordova-plugin-statusbar pull request: Added javascript event on s...
Posted by DamilolaJegede <gi...@git.apache.org>.
Github user DamilolaJegede commented on the pull request:
https://github.com/apache/cordova-plugin-statusbar/pull/4#issuecomment-168313527
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-statusbar pull request: Added javascript event on s...
Posted by Hirbod <gi...@git.apache.org>.
Github user Hirbod commented on the pull request:
https://github.com/apache/cordova-plugin-statusbar/pull/4#issuecomment-93338260
Hello guys, I can't find any information about this nice and very useful function. How can I listen to this event? I've used https://github.com/j-mcnally/cordova-statusTap before, but this plugin is really buggy and breaks with Camera Plugin and IonicKeyboard-Plugin.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-statusbar pull request: Added javascript event on s...
Posted by Hirbod <gi...@git.apache.org>.
Github user Hirbod commented on the pull request:
https://github.com/apache/cordova-plugin-statusbar/pull/4#issuecomment-94870732
@shazron,
it seems like the Google Maps Plugin cause this error:
https://github.com/wf9a5m75/phonegap-googlemaps-plugin
The plugin maintainer added support for the splashscreen plugin (https://github.com/wf9a5m75/phonegap-googlemaps-plugin/commit/3fd283e722740459dc331f8f320ff4e078e44135 before, the mapview just killed the splashscreen) but it seems like the fake scrollview is not "on top" anymore, so the tap won't be triggerd.
https://github.com/j-mcnally/cordova-statusTap worked well, but is very buggy and cause a lot of other problems. I know, this is out of your business, but the maps plugin maintainer is very busy and won't reply to any requests the next months, and I do know have any clue how to fix. Any idea, how I can be sure the fake-scroll-view is always on top?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-statusbar pull request: Added javascript event on s...
Posted by phaitour <gi...@git.apache.org>.
Github user phaitour commented on the pull request:
https://github.com/apache/cordova-plugin-statusbar/pull/4#issuecomment-47439595
@shazron I fixed the merge conflicts.
@agrieve I emailed a signed ICLA.
Thanks
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cordova-plugin-statusbar pull request: Added javascript event on s...
Posted by shazron <gi...@git.apache.org>.
Github user shazron commented on the pull request:
https://github.com/apache/cordova-plugin-statusbar/pull/4#issuecomment-94093160
Hi @Hirbod -- I created a new project, added the ios platform and the statusbar plugin (from github). Then added this:
```window.addEventListener("statusTap", function() { alert('tap'); });```
Launched the project, and tapped the statusbar. It immediately called my function. So I can't repro what you've seen. Can you try with a new project?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-statusbar pull request: Added javascript event on s...
Posted by shazron <gi...@git.apache.org>.
Github user shazron commented on the pull request:
https://github.com/apache/cordova-plugin-statusbar/pull/4#issuecomment-47393316
Github says there are merge conflicts. Up to the PR submitter to resolve them first
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cordova-plugin-statusbar pull request: Added javascript event on s...
Posted by agrieve <gi...@git.apache.org>.
Github user agrieve commented on the pull request:
https://github.com/apache/cordova-plugin-statusbar/pull/4#issuecomment-47389170
Change looks good to me. @phaitour - have you signed the Apache ICLA (can be done online):
http://www.apache.org/licenses/#clas
@shazron - look good to you?
Would benefit from adding docs to doc/index.md as well.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cordova-plugin-statusbar pull request: Added javascript event on s...
Posted by shazron <gi...@git.apache.org>.
Github user shazron commented on the pull request:
https://github.com/apache/cordova-plugin-statusbar/pull/4#issuecomment-94913693
Hi @Hirbod,
Please file a separate issue at https://issues.apache.org/jira/browse/CB. I fear this will be buried in Github since it is already closed (and I don't have the karma to re-open it).
I'm sorry that this is harder than it should be -- we have no control over the mirrored projects on Github, unfortunately :/
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-statusbar pull request: Added javascript event on s...
Posted by shazron <gi...@git.apache.org>.
Github user shazron commented on the pull request:
https://github.com/apache/cordova-plugin-statusbar/pull/4#issuecomment-42090058
Filed: https://issues.apache.org/jira/browse/CB-6626
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cordova-plugin-statusbar pull request: Added javascript event on s...
Posted by Hirbod <gi...@git.apache.org>.
Github user Hirbod commented on the pull request:
https://github.com/apache/cordova-plugin-statusbar/pull/4#issuecomment-93343257
By the way, I've installed 1.0.0-dev via
```
cordova plugin add https://github.com/apache/cordova-plugin-statusbar/
```
and tried to listen to it with
```js
window.addEventListener("statusTap", function() {});
```
but this function won't call.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-statusbar pull request: Added javascript event on s...
Posted by Hirbod <gi...@git.apache.org>.
Github user Hirbod commented on the pull request:
https://github.com/apache/cordova-plugin-statusbar/pull/4#issuecomment-94915215
Is it enough when I just link to our conversation? Or do I need to paste everything again there @shazron ? And thanks for your help!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-statusbar pull request: Added javascript event on s...
Posted by Hirbod <gi...@git.apache.org>.
Github user Hirbod commented on the pull request:
https://github.com/apache/cordova-plugin-statusbar/pull/4#issuecomment-94876888
At least it seems that https://github.com/j-mcnally/cordova-statusTap/blob/master/src/ios/TapToScroll.m is doing something right which doenst get interfere with other plugins. If you ask me, status-bar plugin should handle this cases, where another view could block it
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-statusbar pull request: Added javascript event on s...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-statusbar/pull/4
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cordova-plugin-statusbar pull request: Added javascript event on s...
Posted by Hirbod <gi...@git.apache.org>.
Github user Hirbod commented on the pull request:
https://github.com/apache/cordova-plugin-statusbar/pull/4#issuecomment-94923162
https://issues.apache.org/jira/browse/CB-8886
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-statusbar pull request: Added javascript event on s...
Posted by shazron <gi...@git.apache.org>.
Github user shazron commented on the pull request:
https://github.com/apache/cordova-plugin-statusbar/pull/4#issuecomment-94920959
If you could paste it in (only the relevant parts), that will be great. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org