[GitHub] [pulsar-client-node] gperinazzo commented on issue #56: Add listener support for consumer

[GitBox <gi...@apache.org>]

gperinazzo commented on issue #56: Add listener support for consumer
URL: https://github.com/apache/pulsar-client-node/pull/56#issuecomment-550497192
 
 
   I found a way to pass the original consumer pointer into the message listener, so it doesn't have to wait for the ack to be called. This makes your code snippet work as expected.
   
   However, while doing so, I hit the problem described by https://github.com/nodejs/node-addon-api/issues/592 that lead to a crash after a ThreadSafeFunction was released. I tested with the current master for node-addon-api and it works without any issues.
   
   This should be blocked until the next release of node-addon-api, but if possible could you have a look at the code and give any feedback you can?
   (CI is failing to download node-addon-api from github. It should work once they release the next version and we point to the new release)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services