[GitHub] samza pull request #805: SAMZA-1972: Make Operator Timer metrics calculation...

[xinyuiscool <gi...@git.apache.org>]

GitHub user xinyuiscool opened a pull request:

    https://github.com/apache/samza/pull/805

    SAMZA-1972: Make Operator Timer metrics calculation configurable

    This patch introduces two changes:
    1. Make the timer metrics in OperatorImpl to be optional, and disabled by default. Adding TimerMetrics have quite a big performance impact which affects jobs with large number of operators, so it should be turned for debugging only.
    2. Register the operator-level metrics on the container metrics registry. The task level registry has too many metrics which are usually ignored by the users. Having it in the container level will reduce the total amount of metrics published as well as the memory footprint.
    
    Tested by hello-samza and works as expected.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/xinyuiscool/samza SAMZA-1972

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/samza/pull/805.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #805
    
----
commit 160e22f9a95b0dad76f6bc5a02095b16046b141b
Author: xinyuiscool <xi...@...>
Date:   2018-11-13T18:23:43Z

    SAMZA-1972: Make Operator Timer metrics calculation configurable and off by default

----


---

[GitHub] samza pull request #805: SAMZA-1972: Make Operator Timer metrics calculation...

[asfgit <gi...@git.apache.org>]

Github user asfgit closed the pull request at:

    https://github.com/apache/samza/pull/805


---