[jira] [Commented] (BOOKKEEPER-1028) inc/excl opts listunderreplicate

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/BOOKKEEPER-1028?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16008269#comment-16008269 ] 

ASF GitHub Bot commented on BOOKKEEPER-1028:
--------------------------------------------

Github user eolivelli commented on the issue:

    https://github.com/apache/bookkeeper/pull/127
  
    @reddycharan I have started a review.
    
    All tests run without failures on my laptop (after rebasing to current master)
    Apache Rat check is OK 
    
    But I see the findbugs errors below, can you fix them ?
    Maybe you can rebase to current master, now the full test suite runs in 20 minutes
    
    ```
    [INFO] Result of integer multiplication cast to long in org.apache.bookkeeper.bookie.BookieShell$DecommissionBookieCmd.waitForLedgersToBeReplicated(Collection, BookieSocketAddress, LedgerManager) [org.apache.bookkeeper.bookie.BookieShell$DecommissionBookieCmd] At BookieShell.java:[line 2081] ICAST_INTEGER_MULTIPLY_CAST_TO_LONG
    [INFO] Boxing/unboxing to parse a primitive org.apache.bookkeeper.bookie.BookieShell$LostBookieRecoveryDelayCmd.runCmd(CommandLine) [org.apache.bookkeeper.bookie.BookieShell$LostBookieRecoveryDelayCmd] At BookieShell.java:[line 1403] DM_BOXED_PRIMITIVE_FOR_PARSING
    [INFO] Boxing/unboxing to parse a primitive org.apache.bookkeeper.meta.ZkLedgerUnderreplicationManager.getLostBookieRecoveryDelay() [org.apache.bookkeeper.meta.ZkLedgerUnderreplicationManager] At ZkLedgerUnderreplicationManager.java:[line 741] DM_BOXED_PRIMITIVE_FOR_PARSING
    
    ```


> inc/excl opts listunderreplicate
> --------------------------------
>
>                 Key: BOOKKEEPER-1028
>                 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-1028
>             Project: Bookkeeper
>          Issue Type: New Feature
>            Reporter: Charan Reddy Guttapalem
>            Assignee: Charan Reddy Guttapalem
>            Priority: Minor
>
> - Introduce including and excluding BookieId options
>     for listunderreplicatedLedgers



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)