[jira] [Commented] (HIVE-12926) Another synchronization issues with tez/llap session pool in hs2

["Siddharth Seth (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HIVE-12926?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15116576#comment-15116576 ] 

Siddharth Seth commented on HIVE-12926:
---------------------------------------

We were iterating, removing and then attempting to remove again.
+1 for the patch. It fixes the problem.

I'm not sure why we need a separate method to close default and non-default sessions though. A single shutdown hook, or invocation of stop() should be sufficient ?

> Another synchronization issues with tez/llap session pool in hs2
> ----------------------------------------------------------------
>
>                 Key: HIVE-12926
>                 URL: https://issues.apache.org/jira/browse/HIVE-12926
>             Project: Hive
>          Issue Type: Bug
>          Components: HiveServer2
>    Affects Versions: 2.0.0
>            Reporter: Siddharth Seth
>            Assignee: Sergey Shelukhin
>            Priority: Critical
>         Attachments: HIVE-12926.patch
>
>
> The changes introduced as part of HIVE-12674 causes issues while shutting down hs2 when session pools are used.
> {code}
> java.util.ConcurrentModificationException
>         at java.util.LinkedList$ListItr.checkForComodification(LinkedList.java:966) ~[?:1.8.0_45]
>         at java.util.LinkedList$ListItr.remove(LinkedList.java:921) ~[?:1.8.0_45]
>         at org.apache.hadoop.hive.ql.exec.tez.TezSessionPoolManager.stop(TezSessionPoolManager.java:288) ~[hive-exec-2.0.0.2.3.5.0-79.jar:2.0.0.2.3.5.0-79]
>         at org.apache.hive.service.server.HiveServer2.stop(HiveServer2.java:479) [hive-jdbc-2.0.0.2.3.5.0-79-standalone.jar:2.0.0.2.3.5.0-79]
>         at org.apache.hive.service.server.HiveServer2$2.run(HiveServer2.java:183) [hive-jdbc-2.0.0.2.3.5.0-79-standalone.jar:2.0.0.2.3.5.0-79]
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)