You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/11/17 22:45:21 UTC
[GitHub] [arrow] Dandandan opened a new pull request #8697: ARROW-10572: [Rust][DataFusion] Dependency version updates
Dandandan opened a new pull request #8697:
URL: https://github.com/apache/arrow/pull/8697
Upgrades versions to latest one. Brings in tokio 0.3, crossbeam 0.8 and some smaller updates.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] alamb commented on pull request #8697: ARROW-10633: [Rust][DataFusion] Dependency version updates
Posted by GitBox <gi...@apache.org>.
alamb commented on pull request #8697:
URL: https://github.com/apache/arrow/pull/8697#issuecomment-732441804
@rdettai -- I am also fine downgrading back to tokio 3.0 -- I read some of the discussion on https://github.com/apache/arrow/pull/8734 and it seems like arrow flight is ok?
Can you be clearer about what exactly is breaking for you? Is it downstream dependencies that can't be to get updated to tokio 3.0?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] alamb commented on a change in pull request #8697: ARROW-10633: [Rust][DataFusion] Dependency version updates
Posted by GitBox <gi...@apache.org>.
alamb commented on a change in pull request #8697:
URL: https://github.com/apache/arrow/pull/8697#discussion_r526493179
##########
File path: rust/datafusion/Cargo.toml
##########
@@ -50,14 +50,14 @@ parquet = { path = "../parquet", version = "3.0.0-SNAPSHOT", features = ["arrow"
sqlparser = "0.6.1"
clap = "2.33"
rustyline = {version = "6.0", optional = true}
-crossbeam = "0.7"
-paste = "0.1"
+crossbeam = "0.8"
+paste = "^1.0"
Review comment:
Any reason to add `^` dependency as opposed to just paste = "1.0"?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] rdettai edited a comment on pull request #8697: ARROW-10633: [Rust][DataFusion] Dependency version updates
Posted by GitBox <gi...@apache.org>.
rdettai edited a comment on pull request #8697:
URL: https://github.com/apache/arrow/pull/8697#issuecomment-732125285
@alamb @Dandandan Upgrading Tokio to 0.3 is not as simple as it seems. The runtime is not compatible with the 0.2 one, and it requires to add a compatibility adapter that runs an extra thread (https://docs.rs/tokio-compat-02/0.1.2/tokio_compat_02/).
The problem is that many libraries are still running 0.2 (as 0.3 is fairly recent):
- tonic: flight is mostly broken because of that
- rustoto: not directly used but used by external users (and not just me I guess 😄)
What was the reason for upgrading Tokio? If there is no clear reason, I would be in favor of downgrading back to 0.2.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] rdettai commented on pull request #8697: ARROW-10633: [Rust][DataFusion] Dependency version updates
Posted by GitBox <gi...@apache.org>.
rdettai commented on pull request #8697:
URL: https://github.com/apache/arrow/pull/8697#issuecomment-732125285
@alamb @Dandandan Upgrading Tokio to 0.3 is not as simple as it seams. The runtime is not compatible with the 0.2 one, and it requires to add a compatibility adapter that runs an extra thread (https://docs.rs/tokio-compat-02/0.1.2/tokio_compat_02/).
The problem is that many libraries are still running 0.2 (as 0.3 is fairly recent):
- tonic: flight is mostly broken because of that
- rustoto: not directly used but used by external users (and not just me I guess 😄)
What was the reason for upgrading Tokio? If there is no clear reason, I would be in favor of downgrading back to 0.2.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] Dandandan commented on pull request #8697: ARROW-10633: [Rust][DataFusion] Dependency version updates
Posted by GitBox <gi...@apache.org>.
Dandandan commented on pull request #8697:
URL: https://github.com/apache/arrow/pull/8697#issuecomment-755468767
@rdettai rustoto just released a new version with 1.0 , tonic has an open PR for the upgrade. Any other dependencies we should look out for when upgrading to 1.0?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] alamb commented on pull request #8697: ARROW-10633: [Rust][DataFusion] Dependency version updates
Posted by GitBox <gi...@apache.org>.
alamb commented on pull request #8697:
URL: https://github.com/apache/arrow/pull/8697#issuecomment-732946889
@rdettai -- the same thing fails for me. I filed https://issues.apache.org/jira/browse/ARROW-10710
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] Dandandan commented on pull request #8697: ARROW-10633: [Rust][DataFusion] Dependency version updates
Posted by GitBox <gi...@apache.org>.
Dandandan commented on pull request #8697:
URL: https://github.com/apache/arrow/pull/8697#issuecomment-732184350
@rdettai
The reason was more to upgrade to the latest version to benefit from the changes and to make future upgrades easier (tokio 1.0 is also coming).
For me it would be no problem to downgrade to tokio 0.2 if it causes too much problems elsewhere and wait until other libraries catch up.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] alamb commented on pull request #8697: ARROW-10633: [Rust][DataFusion] Dependency version updates
Posted by GitBox <gi...@apache.org>.
alamb commented on pull request #8697:
URL: https://github.com/apache/arrow/pull/8697#issuecomment-730026146
Thank you @Dandandan !
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] alamb closed pull request #8697: ARROW-10633: [Rust][DataFusion] Dependency version updates
Posted by GitBox <gi...@apache.org>.
alamb closed pull request #8697:
URL: https://github.com/apache/arrow/pull/8697
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] Dandandan edited a comment on pull request #8697: ARROW-10633: [Rust][DataFusion] Dependency version updates
Posted by GitBox <gi...@apache.org>.
Dandandan edited a comment on pull request #8697:
URL: https://github.com/apache/arrow/pull/8697#issuecomment-755468767
@rdettai rusoto just released a new version with 1.0 , tonic has an open PR for the upgrade. Any other dependencies we should look out for when upgrading to 1.0?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #8697: ARROW-10572: [Rust][DataFusion] Dependency version updates
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #8697:
URL: https://github.com/apache/arrow/pull/8697#issuecomment-729259677
https://issues.apache.org/jira/browse/ARROW-10572
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #8697: ARROW-10633: [Rust][DataFusion] Dependency version updates
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #8697:
URL: https://github.com/apache/arrow/pull/8697#issuecomment-729272624
https://issues.apache.org/jira/browse/ARROW-10633
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] rdettai commented on pull request #8697: ARROW-10633: [Rust][DataFusion] Dependency version updates
Posted by GitBox <gi...@apache.org>.
rdettai commented on pull request #8697:
URL: https://github.com/apache/arrow/pull/8697#issuecomment-732936572
Maybe I'm doing something wrong, but if I run:
`cd rust/arrow-flight; cargo run --example server`
on the current master, the server panics. Is it working for you?
I can try to make the example into a test to have this verified automatically, but I wont have time to do it before the end of the week.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org