You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by maropu <gi...@git.apache.org> on 2018/09/03 02:30:27 UTC

[GitHub] spark pull request #22314: [SPARK-25307][SQL] ArraySort function may return ...

Github user maropu commented on a diff in the pull request:

    https://github.com/apache/spark/pull/22314#discussion_r214565311
  
    --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala ---
    @@ -1047,7 +1047,8 @@ trait ArraySortLike extends ExpectsInputTypes {
             s"int $c = ${ctx.genComp(elementType, s"(($jt) $o1)", s"(($jt) $o2)")};"
           }
           val nonNullPrimitiveAscendingSort =
    --- End diff --
    
    `nonNullPrimitiveNumericAscendingSort` or `fastSortCode` preferred?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org