[jira] [Commented] (JCRVLT-116) InstallHookProcessor.Hook should not only use TCCL as fallback

["Tobias Bocanegra (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/JCRVLT-116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15423857#comment-15423857 ] 

Tobias Bocanegra commented on JCRVLT-116:
-----------------------------------------

thanks. [~cziegeler] may I ask you to take a look at the proposed changes? you have a better understanding about the classloaders in felix/sling than I do. thanks.

> InstallHookProcessor.Hook should not only use TCCL as fallback
> --------------------------------------------------------------
>
>                 Key: JCRVLT-116
>                 URL: https://issues.apache.org/jira/browse/JCRVLT-116
>             Project: Jackrabbit FileVault
>          Issue Type: Improvement
>    Affects Versions: 3.1.26
>            Reporter: Konrad Windszus
>
> Currently the {{InstallHookProcessor.Hook}} only uses the thread context class loader as fallback to load the hook classes (https://github.com/apache/jackrabbit-filevault/blob/64caa29325452c1adf968ae05e2308b37f3600cc/vault-core/src/main/java/org/apache/jackrabbit/vault/packaging/impl/InstallHookProcessorImpl.java#L206). This almost never works in an OSGi context.
> Instead I would propose to try the Bundle's Class Loader and add `DynamicImport-Package: *` to the OSGi manifest. 
> That of course would not work in non-OSGi contexts. Therefore it should just be implemented as another fallback option (in addition to TCCL).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)