You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Branko Čibej <br...@xbc.nu> on 2000/10/24 15:40:56 UTC
Let's fix those threading flags
O.K., I've had it up to here [indicates position approximately
0.3048 m above top of head, one left foot to you benighted souls
across the pond] with those hard-coded "-pthread" flags in the
makefiles. I think it's finally time to fix that.
I've attached two patches: the first teaches APR's configure
to export CPPFLAGS and CFLAGS needed for threaded programs
into APRVARS; the second tells SVN's configure to use EXTRA_LIBS,
EXTRA_CFLAGS and EXTRA_CPPFLAGS from APRVARS, and nukes the CFLAGS
definitions in the Makefile.am files.
Greg S, if you can apply the first patch to APR, and if nobody
screams too much, I'll check in the second patch later today or
early tomorrow. I already fixed a typo in berkeley-db.m4 where
CPPFLAGS were set off of LIBS, which broke this brilliant solution
of mine. :-p
Hey, with these patches I can finally build on Solaris! :-))
(No, I don't want to try on AIX right now, but yes, I will soon,
likewise HP-UX and maybe IRIX. Have to see if Berkeley DB builds
on those first. Probably does, but <shrug>.)
An interesting side note: expat-lite inherits the CPPFLAGS,
but not the CFLAGS; neon doesn't care about either. Maybe
this'll have to be fixed, maybe not. Will wait and see.
--
Brane �ibej
home: <br...@xbc.nu> http://www.xbc.nu/brane/
ACM: <br...@acm.org> http://www.acm.org/
Re: Let's fix those threading flags
Posted by Branko Čibej <br...@xbc.nu>.
Greg Stein wrote:
> I've applied the APR portion.
Thanks. And I've applied the SVN part. We rock now on:
* sparc-sun-solaris2.6
* hppa1.1-hp-hpux10.20 (without pthreads, 'cause I don't have them
installed)
By the way, APR on HP-UX 10.20 needs to define _XOPEN_SOURCE_EXTENDED,
otherwise it doesn't see "h_errno" in <netdb.h>. I configured with
CPPFLAGS=-D_XOPEN_SOURCE_EXTENDED ./configure ...
to get around that, but I believe APR's configure should guess that itself.
--
Brane �ibej
home: <br...@xbc.nu> http://www.xbc.nu/brane/
ACM: <br...@acm.org> http://www.acm.org/
Re: Let's fix those threading flags
Posted by Greg Stein <gs...@lyra.org>.
I've applied the APR portion.
On Tue, Oct 24, 2000 at 05:40:56PM +0200, Branko Cibej wrote:
> O.K., I've had it up to here [indicates position approximately
> 0.3048 m above top of head, one left foot to you benighted souls
> across the pond] with those hard-coded "-pthread" flags in the
> makefiles. I think it's finally time to fix that.
>
> I've attached two patches: the first teaches APR's configure
> to export CPPFLAGS and CFLAGS needed for threaded programs
> into APRVARS; the second tells SVN's configure to use EXTRA_LIBS,
> EXTRA_CFLAGS and EXTRA_CPPFLAGS from APRVARS, and nukes the CFLAGS
> definitions in the Makefile.am files.
>
> Greg S, if you can apply the first patch to APR, and if nobody
> screams too much, I'll check in the second patch later today or
> early tomorrow. I already fixed a typo in berkeley-db.m4 where
> CPPFLAGS were set off of LIBS, which broke this brilliant solution
> of mine. :-p
>
> Hey, with these patches I can finally build on Solaris! :-))
> (No, I don't want to try on AIX right now, but yes, I will soon,
> likewise HP-UX and maybe IRIX. Have to see if Berkeley DB builds
> on those first. Probably does, but <shrug>.)
>
>
> An interesting side note: expat-lite inherits the CPPFLAGS,
> but not the CFLAGS; neon doesn't care about either. Maybe
> this'll have to be fixed, maybe not. Will wait and see.
>
> --
> Brane Cibej
> home: <br...@xbc.nu> http://www.xbc.nu/brane/
> ACM: <br...@acm.org> http://www.acm.org/
--
Greg Stein, http://www.lyra.org/