You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Adar Dembo (Code Review)" <ge...@cloudera.org> on 2019/10/16 20:14:27 UTC
[kudu-CR] master: GetTableStatistics should use signed ints
Hello Alexey Serbin, Todd Lipcon,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/14463
to review the following change.
Change subject: master: GetTableStatistics should use signed ints
......................................................................
master: GetTableStatistics should use signed ints
The statistics are reported to the master as signed ints, so the master
should likewise advertise them as such. Otherwise the live_row_count value
of -1 (when a tablet doesn't support it) shows up as:
TABLE test-workload
on disk size: 0
live row count: 18446744073709551615
The public APIs were already treating them as signed; they were only only
unsigned on the wire.
Change-Id: I398cb85888bdc9463264692911788de2fef67dfc
---
M src/kudu/client/table_statistics-internal.h
M src/kudu/master/master.proto
M src/kudu/tools/kudu-tool-test.cc
3 files changed, 24 insertions(+), 7 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/63/14463/1
--
To view, visit http://gerrit.cloudera.org:8080/14463
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I398cb85888bdc9463264692911788de2fef67dfc
Gerrit-Change-Number: 14463
Gerrit-PatchSet: 1
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] master: GetTableStatistics should use signed ints
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/14463 )
Change subject: master: GetTableStatistics should use signed ints
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/14463
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I398cb85888bdc9463264692911788de2fef67dfc
Gerrit-Change-Number: 14463
Gerrit-PatchSet: 1
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Wed, 16 Oct 2019 20:43:05 +0000
Gerrit-HasComments: No
[kudu-CR] master: GetTableStatistics should use signed ints
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/14463 )
Change subject: master: GetTableStatistics should use signed ints
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/14463
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I398cb85888bdc9463264692911788de2fef67dfc
Gerrit-Change-Number: 14463
Gerrit-PatchSet: 1
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Wed, 16 Oct 2019 20:20:05 +0000
Gerrit-HasComments: No
[kudu-CR] master: GetTableStatistics should use signed ints
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14463 )
Change subject: master: GetTableStatistics should use signed ints
......................................................................
master: GetTableStatistics should use signed ints
The statistics are reported to the master as signed ints, so the master
should likewise advertise them as such. Otherwise the live_row_count value
of -1 (when a tablet doesn't support it) shows up as:
TABLE test-workload
on disk size: 0
live row count: 18446744073709551615
The public APIs were already treating them as signed; they were only only
unsigned on the wire.
Change-Id: I398cb85888bdc9463264692911788de2fef67dfc
Reviewed-on: http://gerrit.cloudera.org:8080/14463
Reviewed-by: Grant Henke <gr...@apache.org>
Tested-by: Kudu Jenkins
Reviewed-by: Alexey Serbin <as...@cloudera.com>
---
M src/kudu/client/table_statistics-internal.h
M src/kudu/master/master.proto
M src/kudu/tools/kudu-tool-test.cc
3 files changed, 24 insertions(+), 7 deletions(-)
Approvals:
Grant Henke: Looks good to me, approved
Kudu Jenkins: Verified
Alexey Serbin: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/14463
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I398cb85888bdc9463264692911788de2fef67dfc
Gerrit-Change-Number: 14463
Gerrit-PatchSet: 2
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>