You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2021/03/11 13:28:46 UTC

[GitHub] [flink] lirui-apache opened a new pull request #15155: [FLINK-21660][table-api-java][hive] Stop using is_generic to differen…

lirui-apache opened a new pull request #15155:
URL: https://github.com/apache/flink/pull/15155


   …tiate hive and flink tables
   
   <!--
   *Thank you very much for contributing to Apache Flink - we are happy that you want to help us improve Flink. To help the community review your contribution in the best possible way, please go through the checklist below, which will get the contribution into a shape in which it can be best reviewed.*
   
   *Please understand that we do not do this to make contributions to Flink a hassle. In order to uphold a high standard of quality for code contributions, while at the same time managing a large number of contributions, we need contributors to prepare the contributions well, and give reviewers enough contextual information for the review. Please also understand that contributions that do not follow this guide will take longer to review and thus typically be picked up with lower priority by the community.*
   
   ## Contribution Checklist
   
     - Make sure that the pull request corresponds to a [JIRA issue](https://issues.apache.org/jira/projects/FLINK/issues). Exceptions are made for typos in JavaDoc or documentation files, which need no JIRA issue.
     
     - Name the pull request in the form "[FLINK-XXXX] [component] Title of the pull request", where *FLINK-XXXX* should be replaced by the actual issue number. Skip *component* if you are unsure about which is the best component.
     Typo fixes that have no associated JIRA issue should be named following this pattern: `[hotfix] [docs] Fix typo in event time introduction` or `[hotfix] [javadocs] Expand JavaDoc for PuncuatedWatermarkGenerator`.
   
     - Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
     
     - Make sure that the change passes the automated tests, i.e., `mvn clean verify` passes. You can set up Azure Pipelines CI to do that following [this guide](https://cwiki.apache.org/confluence/display/FLINK/Azure+Pipelines#AzurePipelines-Tutorial:SettingupAzurePipelinesforaforkoftheFlinkrepository).
   
     - Each pull request should address only one issue, not mix up code from multiple issues.
     
     - Each commit in the pull request has a meaningful commit message (including the JIRA id)
   
     - Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.
   
   
   **(The sections below can be removed for hotfixes of typos)**
   -->
   
   ## What is the purpose of the change
   
   Fix the issue that `CREATE TABLE LIKE` cannot reference generic tables stored in HiveCatalog.
   
   
   ## Brief change log
   
     - Stop using `is_generic` flag to differentiate hive and flink tables.
     - For creating, a table with `connector=hive` is considered as a hive table, otherwise it's a generic table.
     - For hive tables, the `connector` property won't be stored to metastore.
     - For retrieving, a table with `connector` property, or with `is_generic=true` is considered as a generic table, otherwise it's a hive table.
   
   
   ## Verifying this change
   
   Added and existing tests.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): no
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
     - The serializers: no
     - The runtime per-record code paths (performance sensitive): no
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: no
     - The S3 file system connector: no
   
   ## Documentation
   
     - Does this pull request introduce a new feature? yes
     - If yes, how is the feature documented? docs
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #15155: [FLINK-21660][table-api-java][hive] Stop using is_generic to differen…

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #15155:
URL: https://github.com/apache/flink/pull/15155#issuecomment-796750000


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "a88d48b0e0330b74133a2f664bf1300f204b1f11",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14479",
       "triggerID" : "a88d48b0e0330b74133a2f664bf1300f204b1f11",
       "triggerType" : "PUSH"
     }, {
       "hash" : "07ff0742be91c9e503b91a31700bacad8fa03edd",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14525",
       "triggerID" : "07ff0742be91c9e503b91a31700bacad8fa03edd",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2a377d94e552020ea9b8c310c99071c822326725",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=15970",
       "triggerID" : "2a377d94e552020ea9b8c310c99071c822326725",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c0ee0ff10082a0299df061aea1e893c7a6471b9a",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=16067",
       "triggerID" : "c0ee0ff10082a0299df061aea1e893c7a6471b9a",
       "triggerType" : "PUSH"
     }, {
       "hash" : "3985c48c6c4c43ea8d7c9fd924ee91d8c1608ae7",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=16296",
       "triggerID" : "3985c48c6c4c43ea8d7c9fd924ee91d8c1608ae7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "0359e7f7b997b5fa08951fd78eccd7626c9bd2c6",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=16337",
       "triggerID" : "0359e7f7b997b5fa08951fd78eccd7626c9bd2c6",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 3985c48c6c4c43ea8d7c9fd924ee91d8c1608ae7 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=16296) 
   * 0359e7f7b997b5fa08951fd78eccd7626c9bd2c6 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=16337) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #15155: [FLINK-21660][table-api-java][hive] Stop using is_generic to differen…

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #15155:
URL: https://github.com/apache/flink/pull/15155#issuecomment-796750000


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "a88d48b0e0330b74133a2f664bf1300f204b1f11",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14479",
       "triggerID" : "a88d48b0e0330b74133a2f664bf1300f204b1f11",
       "triggerType" : "PUSH"
     }, {
       "hash" : "07ff0742be91c9e503b91a31700bacad8fa03edd",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14525",
       "triggerID" : "07ff0742be91c9e503b91a31700bacad8fa03edd",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2a377d94e552020ea9b8c310c99071c822326725",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=15970",
       "triggerID" : "2a377d94e552020ea9b8c310c99071c822326725",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c0ee0ff10082a0299df061aea1e893c7a6471b9a",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=16067",
       "triggerID" : "c0ee0ff10082a0299df061aea1e893c7a6471b9a",
       "triggerType" : "PUSH"
     }, {
       "hash" : "3985c48c6c4c43ea8d7c9fd924ee91d8c1608ae7",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=16296",
       "triggerID" : "3985c48c6c4c43ea8d7c9fd924ee91d8c1608ae7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "0359e7f7b997b5fa08951fd78eccd7626c9bd2c6",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=16337",
       "triggerID" : "0359e7f7b997b5fa08951fd78eccd7626c9bd2c6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "7a60e6f4cb8a38856cba3244b22a79d6c1709824",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=16463",
       "triggerID" : "7a60e6f4cb8a38856cba3244b22a79d6c1709824",
       "triggerType" : "PUSH"
     }, {
       "hash" : "dbe1fccf6545695f1d581225715f760c0dedd322",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=16534",
       "triggerID" : "dbe1fccf6545695f1d581225715f760c0dedd322",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * dbe1fccf6545695f1d581225715f760c0dedd322 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=16534) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #15155: [FLINK-21660][table-api-java][hive] Stop using is_generic to differen…

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #15155:
URL: https://github.com/apache/flink/pull/15155#issuecomment-796750000


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "a88d48b0e0330b74133a2f664bf1300f204b1f11",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14479",
       "triggerID" : "a88d48b0e0330b74133a2f664bf1300f204b1f11",
       "triggerType" : "PUSH"
     }, {
       "hash" : "07ff0742be91c9e503b91a31700bacad8fa03edd",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14525",
       "triggerID" : "07ff0742be91c9e503b91a31700bacad8fa03edd",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 07ff0742be91c9e503b91a31700bacad8fa03edd Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14525) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #15155: [FLINK-21660][table-api-java][hive] Stop using is_generic to differen…

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #15155:
URL: https://github.com/apache/flink/pull/15155#issuecomment-796750000


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "a88d48b0e0330b74133a2f664bf1300f204b1f11",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14479",
       "triggerID" : "a88d48b0e0330b74133a2f664bf1300f204b1f11",
       "triggerType" : "PUSH"
     }, {
       "hash" : "07ff0742be91c9e503b91a31700bacad8fa03edd",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14525",
       "triggerID" : "07ff0742be91c9e503b91a31700bacad8fa03edd",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2a377d94e552020ea9b8c310c99071c822326725",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "2a377d94e552020ea9b8c310c99071c822326725",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 07ff0742be91c9e503b91a31700bacad8fa03edd Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14525) 
   * 2a377d94e552020ea9b8c310c99071c822326725 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #15155: [FLINK-21660][table-api-java][hive] Stop using is_generic to differen…

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #15155:
URL: https://github.com/apache/flink/pull/15155#issuecomment-796750000


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "a88d48b0e0330b74133a2f664bf1300f204b1f11",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14479",
       "triggerID" : "a88d48b0e0330b74133a2f664bf1300f204b1f11",
       "triggerType" : "PUSH"
     }, {
       "hash" : "07ff0742be91c9e503b91a31700bacad8fa03edd",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14525",
       "triggerID" : "07ff0742be91c9e503b91a31700bacad8fa03edd",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2a377d94e552020ea9b8c310c99071c822326725",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=15970",
       "triggerID" : "2a377d94e552020ea9b8c310c99071c822326725",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c0ee0ff10082a0299df061aea1e893c7a6471b9a",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=16067",
       "triggerID" : "c0ee0ff10082a0299df061aea1e893c7a6471b9a",
       "triggerType" : "PUSH"
     }, {
       "hash" : "3985c48c6c4c43ea8d7c9fd924ee91d8c1608ae7",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "3985c48c6c4c43ea8d7c9fd924ee91d8c1608ae7",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * c0ee0ff10082a0299df061aea1e893c7a6471b9a Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=16067) 
   * 3985c48c6c4c43ea8d7c9fd924ee91d8c1608ae7 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #15155: [FLINK-21660][table-api-java][hive] Stop using is_generic to differen…

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #15155:
URL: https://github.com/apache/flink/pull/15155#issuecomment-796750000


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "a88d48b0e0330b74133a2f664bf1300f204b1f11",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14479",
       "triggerID" : "a88d48b0e0330b74133a2f664bf1300f204b1f11",
       "triggerType" : "PUSH"
     }, {
       "hash" : "07ff0742be91c9e503b91a31700bacad8fa03edd",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14525",
       "triggerID" : "07ff0742be91c9e503b91a31700bacad8fa03edd",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2a377d94e552020ea9b8c310c99071c822326725",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=15970",
       "triggerID" : "2a377d94e552020ea9b8c310c99071c822326725",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c0ee0ff10082a0299df061aea1e893c7a6471b9a",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=16067",
       "triggerID" : "c0ee0ff10082a0299df061aea1e893c7a6471b9a",
       "triggerType" : "PUSH"
     }, {
       "hash" : "3985c48c6c4c43ea8d7c9fd924ee91d8c1608ae7",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=16296",
       "triggerID" : "3985c48c6c4c43ea8d7c9fd924ee91d8c1608ae7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "0359e7f7b997b5fa08951fd78eccd7626c9bd2c6",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=16337",
       "triggerID" : "0359e7f7b997b5fa08951fd78eccd7626c9bd2c6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "7a60e6f4cb8a38856cba3244b22a79d6c1709824",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=16463",
       "triggerID" : "7a60e6f4cb8a38856cba3244b22a79d6c1709824",
       "triggerType" : "PUSH"
     }, {
       "hash" : "dbe1fccf6545695f1d581225715f760c0dedd322",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "dbe1fccf6545695f1d581225715f760c0dedd322",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 7a60e6f4cb8a38856cba3244b22a79d6c1709824 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=16463) 
   * dbe1fccf6545695f1d581225715f760c0dedd322 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #15155: [FLINK-21660][table-api-java][hive] Stop using is_generic to differen…

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #15155:
URL: https://github.com/apache/flink/pull/15155#issuecomment-796750000


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "a88d48b0e0330b74133a2f664bf1300f204b1f11",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14479",
       "triggerID" : "a88d48b0e0330b74133a2f664bf1300f204b1f11",
       "triggerType" : "PUSH"
     }, {
       "hash" : "07ff0742be91c9e503b91a31700bacad8fa03edd",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "07ff0742be91c9e503b91a31700bacad8fa03edd",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * a88d48b0e0330b74133a2f664bf1300f204b1f11 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14479) 
   * 07ff0742be91c9e503b91a31700bacad8fa03edd UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot commented on pull request #15155: [FLINK-21660][table-api-java][hive] Stop using is_generic to differen…

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #15155:
URL: https://github.com/apache/flink/pull/15155#issuecomment-796736723


   Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress of the review.
   
   
   ## Automated Checks
   Last check on commit a88d48b0e0330b74133a2f664bf1300f204b1f11 (Thu Mar 11 13:30:59 UTC 2021)
   
   **Warnings:**
    * No documentation files were touched! Remember to keep the Flink docs up to date!
    * **This pull request references an unassigned [Jira ticket](https://issues.apache.org/jira/browse/FLINK-21660).** According to the [code contribution guide](https://flink.apache.org/contributing/contribute-code.html), tickets need to be assigned before starting with the implementation work.
   
   
   <sub>Mention the bot in a comment to re-run the automated checks.</sub>
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
    The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
    - `@flinkbot approve all` to approve all aspects
    - `@flinkbot approve-until architecture` to approve everything until `architecture`
    - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
    - `@flinkbot disapprove architecture` to remove an approval you gave earlier
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot commented on pull request #15155: [FLINK-21660][table-api-java][hive] Stop using is_generic to differen…

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #15155:
URL: https://github.com/apache/flink/pull/15155#issuecomment-796750000


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "a88d48b0e0330b74133a2f664bf1300f204b1f11",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "a88d48b0e0330b74133a2f664bf1300f204b1f11",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * a88d48b0e0330b74133a2f664bf1300f204b1f11 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] KurtYoung commented on a change in pull request #15155: [FLINK-21660][table-api-java][hive] Stop using is_generic to differen…

Posted by GitBox <gi...@apache.org>.
KurtYoung commented on a change in pull request #15155:
URL: https://github.com/apache/flink/pull/15155#discussion_r611315623



##########
File path: flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/table/catalog/hive/HiveDatabaseUtil.java
##########
@@ -44,7 +43,9 @@ static Database instantiateHiveDatabase(String databaseName, CatalogDatabase dat
 
         Map<String, String> properties = database.getProperties();
 
-        boolean isGeneric = isGenericForCreate(properties);
+        properties.putIfAbsent(CatalogPropertiesUtil.IS_GENERIC, "true");

Review comment:
       This might make sense during the process of `createDatabase` (This method is only called in HiveCatalog#createDatabase), but it doesn't make sense in this utility class. If anyone else used such util method in other places, I don't think they will expect such behavior.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] KurtYoung merged pull request #15155: [FLINK-21660][table-api-java][hive] Stop using is_generic to differen…

Posted by GitBox <gi...@apache.org>.
KurtYoung merged pull request #15155:
URL: https://github.com/apache/flink/pull/15155


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] lirui-apache commented on pull request #15155: [FLINK-21660][table-api-java][hive] Stop using is_generic to differen…

Posted by GitBox <gi...@apache.org>.
lirui-apache commented on pull request #15155:
URL: https://github.com/apache/flink/pull/15155#issuecomment-817446456


   Thanks @KurtYoung for reviewing the PR. I have updated to address your comments.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #15155: [FLINK-21660][table-api-java][hive] Stop using is_generic to differen…

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #15155:
URL: https://github.com/apache/flink/pull/15155#issuecomment-796750000


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "a88d48b0e0330b74133a2f664bf1300f204b1f11",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14479",
       "triggerID" : "a88d48b0e0330b74133a2f664bf1300f204b1f11",
       "triggerType" : "PUSH"
     }, {
       "hash" : "07ff0742be91c9e503b91a31700bacad8fa03edd",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14525",
       "triggerID" : "07ff0742be91c9e503b91a31700bacad8fa03edd",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2a377d94e552020ea9b8c310c99071c822326725",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=15970",
       "triggerID" : "2a377d94e552020ea9b8c310c99071c822326725",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c0ee0ff10082a0299df061aea1e893c7a6471b9a",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=16067",
       "triggerID" : "c0ee0ff10082a0299df061aea1e893c7a6471b9a",
       "triggerType" : "PUSH"
     }, {
       "hash" : "3985c48c6c4c43ea8d7c9fd924ee91d8c1608ae7",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=16296",
       "triggerID" : "3985c48c6c4c43ea8d7c9fd924ee91d8c1608ae7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "0359e7f7b997b5fa08951fd78eccd7626c9bd2c6",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=16337",
       "triggerID" : "0359e7f7b997b5fa08951fd78eccd7626c9bd2c6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "7a60e6f4cb8a38856cba3244b22a79d6c1709824",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=16463",
       "triggerID" : "7a60e6f4cb8a38856cba3244b22a79d6c1709824",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 0359e7f7b997b5fa08951fd78eccd7626c9bd2c6 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=16337) 
   * 7a60e6f4cb8a38856cba3244b22a79d6c1709824 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=16463) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #15155: [FLINK-21660][table-api-java][hive] Stop using is_generic to differen…

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #15155:
URL: https://github.com/apache/flink/pull/15155#issuecomment-796750000


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "a88d48b0e0330b74133a2f664bf1300f204b1f11",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14479",
       "triggerID" : "a88d48b0e0330b74133a2f664bf1300f204b1f11",
       "triggerType" : "PUSH"
     }, {
       "hash" : "07ff0742be91c9e503b91a31700bacad8fa03edd",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14525",
       "triggerID" : "07ff0742be91c9e503b91a31700bacad8fa03edd",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2a377d94e552020ea9b8c310c99071c822326725",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=15970",
       "triggerID" : "2a377d94e552020ea9b8c310c99071c822326725",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 07ff0742be91c9e503b91a31700bacad8fa03edd Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14525) 
   * 2a377d94e552020ea9b8c310c99071c822326725 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=15970) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] KurtYoung commented on pull request #15155: [FLINK-21660][table-api-java][hive] Stop using is_generic to differen…

Posted by GitBox <gi...@apache.org>.
KurtYoung commented on pull request #15155:
URL: https://github.com/apache/flink/pull/15155#issuecomment-816485224


   Am I understand this correctly:
   
   Old behavior:
   - `is_generic = true`: non-hive table
   - `is_generic = false` or `no is_generic`: hive table
   
   New behavior:
   - `connector = xxx(not hive)`: non-hive table
   - `connector = hive` or `no connector`: hive table
   
    


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #15155: [FLINK-21660][table-api-java][hive] Stop using is_generic to differen…

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #15155:
URL: https://github.com/apache/flink/pull/15155#issuecomment-796750000


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "a88d48b0e0330b74133a2f664bf1300f204b1f11",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14479",
       "triggerID" : "a88d48b0e0330b74133a2f664bf1300f204b1f11",
       "triggerType" : "PUSH"
     }, {
       "hash" : "07ff0742be91c9e503b91a31700bacad8fa03edd",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14525",
       "triggerID" : "07ff0742be91c9e503b91a31700bacad8fa03edd",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2a377d94e552020ea9b8c310c99071c822326725",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=15970",
       "triggerID" : "2a377d94e552020ea9b8c310c99071c822326725",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c0ee0ff10082a0299df061aea1e893c7a6471b9a",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "c0ee0ff10082a0299df061aea1e893c7a6471b9a",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 2a377d94e552020ea9b8c310c99071c822326725 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=15970) 
   * c0ee0ff10082a0299df061aea1e893c7a6471b9a UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] KurtYoung commented on a change in pull request #15155: [FLINK-21660][table-api-java][hive] Stop using is_generic to differen…

Posted by GitBox <gi...@apache.org>.
KurtYoung commented on a change in pull request #15155:
URL: https://github.com/apache/flink/pull/15155#discussion_r611144110



##########
File path: flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/table/catalog/hive/HiveCatalog.java
##########
@@ -822,18 +843,15 @@ public void createPartition(
         checkNotNull(partitionSpec, "CatalogPartitionSpec cannot be null");
         checkNotNull(partition, "Partition cannot be null");
 
-        boolean isGeneric =
-                Boolean.valueOf(partition.getProperties().get(CatalogPropertiesUtil.IS_GENERIC));
-
-        if (isGeneric) {
-            throw new CatalogException("Currently only supports non-generic CatalogPartition");
-        }
-
         Table hiveTable = getHiveTable(tablePath);
+        ensurePartitionedTable(tablePath, hiveTable);
 
-        ensureTableAndPartitionMatch(hiveTable, partition);
+        // partition inherits 'is_generic' from table

Review comment:
       wrong comment? we don't use is_generic anymore

##########
File path: flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/connectors/hive/HiveTableFactory.java
##########
@@ -51,11 +51,10 @@ public TableSource createTableSource(TableSourceFactory.Context context) {
         CatalogTable table = checkNotNull(context.getTable());
         Preconditions.checkArgument(table instanceof CatalogTableImpl);
 
-        boolean isGeneric =
-                Boolean.parseBoolean(table.getOptions().get(CatalogPropertiesUtil.IS_GENERIC));
+        boolean isHiveTable = HiveCatalog.isHiveTable(table.getOptions());
 
-        // temporary table doesn't have the IS_GENERIC flag but we still consider it generic
-        if (!isGeneric && !context.isTemporary()) {
+        // temporary table is considered generic
+        if (isHiveTable && !context.isTemporary()) {
             throw new UnsupportedOperationException(
                     "Hive table should be resolved by HiveDynamicTableFactory.");

Review comment:
       throw a more meaningful message
   
   

##########
File path: flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/table/catalog/hive/HiveDatabaseUtil.java
##########
@@ -44,7 +43,9 @@ static Database instantiateHiveDatabase(String databaseName, CatalogDatabase dat
 
         Map<String, String> properties = database.getProperties();
 
-        boolean isGeneric = isGenericForCreate(properties);
+        properties.putIfAbsent(CatalogPropertiesUtil.IS_GENERIC, "true");

Review comment:
       why set is_generic=true here?

##########
File path: flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/table/catalog/hive/HiveCatalog.java
##########
@@ -587,9 +588,16 @@ public void alterTable(
                         newCatalogTable.getOptions(),
                         hiveTable.getSd());
             }
+        } else {
+            hiveTable =
+                    HiveTableUtil.alterTableViaCatalogBaseTable(
+                            tablePath, newCatalogTable, hiveTable, hiveConf);
         }
 
-        disallowChangeIsGeneric(isGeneric, isGenericForGet(hiveTable.getParameters()));
+        disallowChangeIsGeneric(isHiveTable, isHiveTable(hiveTable.getParameters()));

Review comment:
       modify the method name

##########
File path: flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/connectors/hive/HiveTableFactory.java
##########
@@ -68,11 +67,10 @@ public TableSink createTableSink(TableSinkFactory.Context context) {
         CatalogTable table = checkNotNull(context.getTable());
         Preconditions.checkArgument(table instanceof CatalogTableImpl);
 
-        boolean isGeneric =
-                Boolean.parseBoolean(table.getOptions().get(CatalogPropertiesUtil.IS_GENERIC));
+        boolean isHiveTable = HiveCatalog.isHiveTable(table.getOptions());
 
         // temporary table doesn't have the IS_GENERIC flag but we still consider it generic
-        if (!isGeneric && !context.isTemporary()) {
+        if (isHiveTable && !context.isTemporary()) {
             throw new UnsupportedOperationException(
                     "Hive table should be resolved by HiveDynamicTableFactory.");

Review comment:
       throw a more meaningful message




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #15155: [FLINK-21660][table-api-java][hive] Stop using is_generic to differen…

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #15155:
URL: https://github.com/apache/flink/pull/15155#issuecomment-796750000


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "a88d48b0e0330b74133a2f664bf1300f204b1f11",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14479",
       "triggerID" : "a88d48b0e0330b74133a2f664bf1300f204b1f11",
       "triggerType" : "PUSH"
     }, {
       "hash" : "07ff0742be91c9e503b91a31700bacad8fa03edd",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14525",
       "triggerID" : "07ff0742be91c9e503b91a31700bacad8fa03edd",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2a377d94e552020ea9b8c310c99071c822326725",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=15970",
       "triggerID" : "2a377d94e552020ea9b8c310c99071c822326725",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c0ee0ff10082a0299df061aea1e893c7a6471b9a",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=16067",
       "triggerID" : "c0ee0ff10082a0299df061aea1e893c7a6471b9a",
       "triggerType" : "PUSH"
     }, {
       "hash" : "3985c48c6c4c43ea8d7c9fd924ee91d8c1608ae7",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=16296",
       "triggerID" : "3985c48c6c4c43ea8d7c9fd924ee91d8c1608ae7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "0359e7f7b997b5fa08951fd78eccd7626c9bd2c6",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=16337",
       "triggerID" : "0359e7f7b997b5fa08951fd78eccd7626c9bd2c6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "7a60e6f4cb8a38856cba3244b22a79d6c1709824",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "7a60e6f4cb8a38856cba3244b22a79d6c1709824",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 0359e7f7b997b5fa08951fd78eccd7626c9bd2c6 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=16337) 
   * 7a60e6f4cb8a38856cba3244b22a79d6c1709824 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #15155: [FLINK-21660][table-api-java][hive] Stop using is_generic to differen…

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #15155:
URL: https://github.com/apache/flink/pull/15155#issuecomment-796750000


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "a88d48b0e0330b74133a2f664bf1300f204b1f11",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14479",
       "triggerID" : "a88d48b0e0330b74133a2f664bf1300f204b1f11",
       "triggerType" : "PUSH"
     }, {
       "hash" : "07ff0742be91c9e503b91a31700bacad8fa03edd",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14525",
       "triggerID" : "07ff0742be91c9e503b91a31700bacad8fa03edd",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2a377d94e552020ea9b8c310c99071c822326725",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=15970",
       "triggerID" : "2a377d94e552020ea9b8c310c99071c822326725",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c0ee0ff10082a0299df061aea1e893c7a6471b9a",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=16067",
       "triggerID" : "c0ee0ff10082a0299df061aea1e893c7a6471b9a",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * c0ee0ff10082a0299df061aea1e893c7a6471b9a Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=16067) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #15155: [FLINK-21660][table-api-java][hive] Stop using is_generic to differen…

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #15155:
URL: https://github.com/apache/flink/pull/15155#issuecomment-796750000


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "a88d48b0e0330b74133a2f664bf1300f204b1f11",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14479",
       "triggerID" : "a88d48b0e0330b74133a2f664bf1300f204b1f11",
       "triggerType" : "PUSH"
     }, {
       "hash" : "07ff0742be91c9e503b91a31700bacad8fa03edd",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14525",
       "triggerID" : "07ff0742be91c9e503b91a31700bacad8fa03edd",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2a377d94e552020ea9b8c310c99071c822326725",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=15970",
       "triggerID" : "2a377d94e552020ea9b8c310c99071c822326725",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c0ee0ff10082a0299df061aea1e893c7a6471b9a",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=16067",
       "triggerID" : "c0ee0ff10082a0299df061aea1e893c7a6471b9a",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 2a377d94e552020ea9b8c310c99071c822326725 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=15970) 
   * c0ee0ff10082a0299df061aea1e893c7a6471b9a Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=16067) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #15155: [FLINK-21660][table-api-java][hive] Stop using is_generic to differen…

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #15155:
URL: https://github.com/apache/flink/pull/15155#issuecomment-796750000


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "a88d48b0e0330b74133a2f664bf1300f204b1f11",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14479",
       "triggerID" : "a88d48b0e0330b74133a2f664bf1300f204b1f11",
       "triggerType" : "PUSH"
     }, {
       "hash" : "07ff0742be91c9e503b91a31700bacad8fa03edd",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14525",
       "triggerID" : "07ff0742be91c9e503b91a31700bacad8fa03edd",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * a88d48b0e0330b74133a2f664bf1300f204b1f11 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14479) 
   * 07ff0742be91c9e503b91a31700bacad8fa03edd Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14525) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #15155: [FLINK-21660][table-api-java][hive] Stop using is_generic to differen…

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #15155:
URL: https://github.com/apache/flink/pull/15155#issuecomment-796750000


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "a88d48b0e0330b74133a2f664bf1300f204b1f11",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14479",
       "triggerID" : "a88d48b0e0330b74133a2f664bf1300f204b1f11",
       "triggerType" : "PUSH"
     }, {
       "hash" : "07ff0742be91c9e503b91a31700bacad8fa03edd",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14525",
       "triggerID" : "07ff0742be91c9e503b91a31700bacad8fa03edd",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2a377d94e552020ea9b8c310c99071c822326725",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=15970",
       "triggerID" : "2a377d94e552020ea9b8c310c99071c822326725",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c0ee0ff10082a0299df061aea1e893c7a6471b9a",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=16067",
       "triggerID" : "c0ee0ff10082a0299df061aea1e893c7a6471b9a",
       "triggerType" : "PUSH"
     }, {
       "hash" : "3985c48c6c4c43ea8d7c9fd924ee91d8c1608ae7",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=16296",
       "triggerID" : "3985c48c6c4c43ea8d7c9fd924ee91d8c1608ae7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "0359e7f7b997b5fa08951fd78eccd7626c9bd2c6",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "0359e7f7b997b5fa08951fd78eccd7626c9bd2c6",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 3985c48c6c4c43ea8d7c9fd924ee91d8c1608ae7 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=16296) 
   * 0359e7f7b997b5fa08951fd78eccd7626c9bd2c6 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #15155: [FLINK-21660][table-api-java][hive] Stop using is_generic to differen…

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #15155:
URL: https://github.com/apache/flink/pull/15155#issuecomment-796750000


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "a88d48b0e0330b74133a2f664bf1300f204b1f11",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14479",
       "triggerID" : "a88d48b0e0330b74133a2f664bf1300f204b1f11",
       "triggerType" : "PUSH"
     }, {
       "hash" : "07ff0742be91c9e503b91a31700bacad8fa03edd",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14525",
       "triggerID" : "07ff0742be91c9e503b91a31700bacad8fa03edd",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2a377d94e552020ea9b8c310c99071c822326725",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=15970",
       "triggerID" : "2a377d94e552020ea9b8c310c99071c822326725",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c0ee0ff10082a0299df061aea1e893c7a6471b9a",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=16067",
       "triggerID" : "c0ee0ff10082a0299df061aea1e893c7a6471b9a",
       "triggerType" : "PUSH"
     }, {
       "hash" : "3985c48c6c4c43ea8d7c9fd924ee91d8c1608ae7",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=16296",
       "triggerID" : "3985c48c6c4c43ea8d7c9fd924ee91d8c1608ae7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "0359e7f7b997b5fa08951fd78eccd7626c9bd2c6",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=16337",
       "triggerID" : "0359e7f7b997b5fa08951fd78eccd7626c9bd2c6",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 0359e7f7b997b5fa08951fd78eccd7626c9bd2c6 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=16337) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #15155: [FLINK-21660][table-api-java][hive] Stop using is_generic to differen…

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #15155:
URL: https://github.com/apache/flink/pull/15155#issuecomment-796750000


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "a88d48b0e0330b74133a2f664bf1300f204b1f11",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14479",
       "triggerID" : "a88d48b0e0330b74133a2f664bf1300f204b1f11",
       "triggerType" : "PUSH"
     }, {
       "hash" : "07ff0742be91c9e503b91a31700bacad8fa03edd",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14525",
       "triggerID" : "07ff0742be91c9e503b91a31700bacad8fa03edd",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2a377d94e552020ea9b8c310c99071c822326725",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=15970",
       "triggerID" : "2a377d94e552020ea9b8c310c99071c822326725",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c0ee0ff10082a0299df061aea1e893c7a6471b9a",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=16067",
       "triggerID" : "c0ee0ff10082a0299df061aea1e893c7a6471b9a",
       "triggerType" : "PUSH"
     }, {
       "hash" : "3985c48c6c4c43ea8d7c9fd924ee91d8c1608ae7",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=16296",
       "triggerID" : "3985c48c6c4c43ea8d7c9fd924ee91d8c1608ae7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "0359e7f7b997b5fa08951fd78eccd7626c9bd2c6",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=16337",
       "triggerID" : "0359e7f7b997b5fa08951fd78eccd7626c9bd2c6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "7a60e6f4cb8a38856cba3244b22a79d6c1709824",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=16463",
       "triggerID" : "7a60e6f4cb8a38856cba3244b22a79d6c1709824",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 7a60e6f4cb8a38856cba3244b22a79d6c1709824 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=16463) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #15155: [FLINK-21660][table-api-java][hive] Stop using is_generic to differen…

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #15155:
URL: https://github.com/apache/flink/pull/15155#issuecomment-796750000


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "a88d48b0e0330b74133a2f664bf1300f204b1f11",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14479",
       "triggerID" : "a88d48b0e0330b74133a2f664bf1300f204b1f11",
       "triggerType" : "PUSH"
     }, {
       "hash" : "07ff0742be91c9e503b91a31700bacad8fa03edd",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14525",
       "triggerID" : "07ff0742be91c9e503b91a31700bacad8fa03edd",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2a377d94e552020ea9b8c310c99071c822326725",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=15970",
       "triggerID" : "2a377d94e552020ea9b8c310c99071c822326725",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 2a377d94e552020ea9b8c310c99071c822326725 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=15970) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #15155: [FLINK-21660][table-api-java][hive] Stop using is_generic to differen…

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #15155:
URL: https://github.com/apache/flink/pull/15155#issuecomment-796750000


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "a88d48b0e0330b74133a2f664bf1300f204b1f11",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14479",
       "triggerID" : "a88d48b0e0330b74133a2f664bf1300f204b1f11",
       "triggerType" : "PUSH"
     }, {
       "hash" : "07ff0742be91c9e503b91a31700bacad8fa03edd",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14525",
       "triggerID" : "07ff0742be91c9e503b91a31700bacad8fa03edd",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2a377d94e552020ea9b8c310c99071c822326725",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=15970",
       "triggerID" : "2a377d94e552020ea9b8c310c99071c822326725",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c0ee0ff10082a0299df061aea1e893c7a6471b9a",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=16067",
       "triggerID" : "c0ee0ff10082a0299df061aea1e893c7a6471b9a",
       "triggerType" : "PUSH"
     }, {
       "hash" : "3985c48c6c4c43ea8d7c9fd924ee91d8c1608ae7",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=16296",
       "triggerID" : "3985c48c6c4c43ea8d7c9fd924ee91d8c1608ae7",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * c0ee0ff10082a0299df061aea1e893c7a6471b9a Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=16067) 
   * 3985c48c6c4c43ea8d7c9fd924ee91d8c1608ae7 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=16296) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #15155: [FLINK-21660][table-api-java][hive] Stop using is_generic to differen…

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #15155:
URL: https://github.com/apache/flink/pull/15155#issuecomment-796750000


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "a88d48b0e0330b74133a2f664bf1300f204b1f11",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14479",
       "triggerID" : "a88d48b0e0330b74133a2f664bf1300f204b1f11",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * a88d48b0e0330b74133a2f664bf1300f204b1f11 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14479) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] lirui-apache commented on a change in pull request #15155: [FLINK-21660][table-api-java][hive] Stop using is_generic to differen…

Posted by GitBox <gi...@apache.org>.
lirui-apache commented on a change in pull request #15155:
URL: https://github.com/apache/flink/pull/15155#discussion_r612426937



##########
File path: flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/table/catalog/hive/HiveDatabaseUtil.java
##########
@@ -44,7 +43,9 @@ static Database instantiateHiveDatabase(String databaseName, CatalogDatabase dat
 
         Map<String, String> properties = database.getProperties();
 
-        boolean isGeneric = isGenericForCreate(properties);
+        properties.putIfAbsent(CatalogPropertiesUtil.IS_GENERIC, "true");

Review comment:
       I have updated the PR and we don't need to treat flink and hive databases differently.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #15155: [FLINK-21660][table-api-java][hive] Stop using is_generic to differen…

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #15155:
URL: https://github.com/apache/flink/pull/15155#issuecomment-796750000


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "a88d48b0e0330b74133a2f664bf1300f204b1f11",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14479",
       "triggerID" : "a88d48b0e0330b74133a2f664bf1300f204b1f11",
       "triggerType" : "PUSH"
     }, {
       "hash" : "07ff0742be91c9e503b91a31700bacad8fa03edd",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14525",
       "triggerID" : "07ff0742be91c9e503b91a31700bacad8fa03edd",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2a377d94e552020ea9b8c310c99071c822326725",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=15970",
       "triggerID" : "2a377d94e552020ea9b8c310c99071c822326725",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c0ee0ff10082a0299df061aea1e893c7a6471b9a",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=16067",
       "triggerID" : "c0ee0ff10082a0299df061aea1e893c7a6471b9a",
       "triggerType" : "PUSH"
     }, {
       "hash" : "3985c48c6c4c43ea8d7c9fd924ee91d8c1608ae7",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=16296",
       "triggerID" : "3985c48c6c4c43ea8d7c9fd924ee91d8c1608ae7",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 3985c48c6c4c43ea8d7c9fd924ee91d8c1608ae7 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=16296) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] KurtYoung commented on a change in pull request #15155: [FLINK-21660][table-api-java][hive] Stop using is_generic to differen…

Posted by GitBox <gi...@apache.org>.
KurtYoung commented on a change in pull request #15155:
URL: https://github.com/apache/flink/pull/15155#discussion_r613063699



##########
File path: flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/table/catalog/hive/HiveDatabaseUtil.java
##########
@@ -32,8 +33,6 @@
 import static org.apache.flink.sql.parser.hive.ddl.SqlAlterHiveDatabase.ALTER_DATABASE_OP;
 import static org.apache.flink.sql.parser.hive.ddl.SqlAlterHiveDatabaseOwner.DATABASE_OWNER_NAME;
 import static org.apache.flink.sql.parser.hive.ddl.SqlAlterHiveDatabaseOwner.DATABASE_OWNER_TYPE;
-import static org.apache.flink.table.catalog.hive.HiveCatalog.isGenericForCreate;
-import static org.apache.flink.table.catalog.hive.HiveCatalog.isGenericForGet;
 
 /** Util methods for processing databases in HiveCatalog. */
 public class HiveDatabaseUtil {

Review comment:
       I think this class shouldn't exist, all the methods should be private method in HiveCatalog

##########
File path: flink-table/flink-table-common/src/test/java/org/apache/flink/table/catalog/CatalogTestUtil.java
##########
@@ -209,4 +206,8 @@ private static void checkEquals(
     private static void checkEquals(Date v1, Date v2) {
         assertEquals(v1.getDaysSinceEpoch(), v2.getDaysSinceEpoch());
     }
+
+    private static boolean isGeneric(Map<String, String> properties) {

Review comment:
       rename this method to `isHiveTable`




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] lirui-apache commented on a change in pull request #15155: [FLINK-21660][table-api-java][hive] Stop using is_generic to differen…

Posted by GitBox <gi...@apache.org>.
lirui-apache commented on a change in pull request #15155:
URL: https://github.com/apache/flink/pull/15155#discussion_r611298544



##########
File path: flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/table/catalog/hive/HiveDatabaseUtil.java
##########
@@ -44,7 +43,9 @@ static Database instantiateHiveDatabase(String databaseName, CatalogDatabase dat
 
         Map<String, String> properties = database.getProperties();
 
-        boolean isGeneric = isGenericForCreate(properties);
+        properties.putIfAbsent(CatalogPropertiesUtil.IS_GENERIC, "true");

Review comment:
       If the database properties don't have the `is_generic` key, it's considered generic by default.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #15155: [FLINK-21660][table-api-java][hive] Stop using is_generic to differen…

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #15155:
URL: https://github.com/apache/flink/pull/15155#issuecomment-796750000


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "a88d48b0e0330b74133a2f664bf1300f204b1f11",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14479",
       "triggerID" : "a88d48b0e0330b74133a2f664bf1300f204b1f11",
       "triggerType" : "PUSH"
     }, {
       "hash" : "07ff0742be91c9e503b91a31700bacad8fa03edd",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14525",
       "triggerID" : "07ff0742be91c9e503b91a31700bacad8fa03edd",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2a377d94e552020ea9b8c310c99071c822326725",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=15970",
       "triggerID" : "2a377d94e552020ea9b8c310c99071c822326725",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c0ee0ff10082a0299df061aea1e893c7a6471b9a",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=16067",
       "triggerID" : "c0ee0ff10082a0299df061aea1e893c7a6471b9a",
       "triggerType" : "PUSH"
     }, {
       "hash" : "3985c48c6c4c43ea8d7c9fd924ee91d8c1608ae7",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=16296",
       "triggerID" : "3985c48c6c4c43ea8d7c9fd924ee91d8c1608ae7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "0359e7f7b997b5fa08951fd78eccd7626c9bd2c6",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=16337",
       "triggerID" : "0359e7f7b997b5fa08951fd78eccd7626c9bd2c6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "7a60e6f4cb8a38856cba3244b22a79d6c1709824",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=16463",
       "triggerID" : "7a60e6f4cb8a38856cba3244b22a79d6c1709824",
       "triggerType" : "PUSH"
     }, {
       "hash" : "dbe1fccf6545695f1d581225715f760c0dedd322",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=16534",
       "triggerID" : "dbe1fccf6545695f1d581225715f760c0dedd322",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 7a60e6f4cb8a38856cba3244b22a79d6c1709824 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=16463) 
   * dbe1fccf6545695f1d581225715f760c0dedd322 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=16534) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #15155: [FLINK-21660][table-api-java][hive] Stop using is_generic to differen…

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #15155:
URL: https://github.com/apache/flink/pull/15155#issuecomment-796736723


   Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress of the review.
   
   
   ## Automated Checks
   Last check on commit dbe1fccf6545695f1d581225715f760c0dedd322 (Fri May 28 09:06:54 UTC 2021)
   
   **Warnings:**
    * No documentation files were touched! Remember to keep the Flink docs up to date!
   
   
   <sub>Mention the bot in a comment to re-run the automated checks.</sub>
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
    The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
    - `@flinkbot approve all` to approve all aspects
    - `@flinkbot approve-until architecture` to approve everything until `architecture`
    - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
    - `@flinkbot disapprove architecture` to remove an approval you gave earlier
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org